Project

General

Profile

Actions
Copy link

Feature #7508

closed

Clean up some more calls to rb_intern()

Feature #7508: Clean up some more calls to rb_intern()

Added by Anonymous almost 13 years ago. Updated almost 12 years ago.

Status:
Closed
Assignee:
-
Target version:
2.1.0
[ruby-core:50552]

Description

Related to #7495, I cleaned up a few more calls to rb_intern, replacing some with IDs defined in id.h, and others with IDs interned once on initialization and then cached.

Files

clean_up_rb_interns.patch (16.1 KB) clean_up_rb_interns.patch Anonymous, 12/04/2012 06:54 PM

Updated by usa (Usaku NAKAMURA) almost 13 years ago Actions
Copy link
 #1

  • Category set to core
  • Status changed from Open to Assigned
  • Target version set to 2.0.0
  • Assignee set to Anonymous

IMO, it's OK.
Does anyone have another opinion?

Updated by Glass_saga (Masaki Matsushita) almost 13 years ago Actions
Copy link
 #2

  • Tracker changed from Bug to Feature

Updated by Anonymous over 12 years ago Actions
Copy link
 #3 [ruby-core:52342]

  • Target version changed from 2.0.0 to 2.6

Whoops I forgot about this ticket.

I'll commit it soon.

Updated by ko1 (Koichi Sasada) over 12 years ago Actions
Copy link
 #4 [ruby-core:52347]

  • Target version changed from 2.6 to 2.1.0

I have an opinion.

I want to move all static IDs move to defs/id.def. I have no objection with this patch. But all of replace can be replaced after that.

What do you think about?

Updated by nobu (Nobuyoshi Nakada) almost 12 years ago Actions
Copy link
 #5 [ruby-core:59101]

Why not idCmp and idPow in array.c?

Updated by Anonymous almost 12 years ago Actions
Copy link
 #6 [ruby-core:59103]

  • Status changed from Assigned to Closed

nobu: I'll close this ticket - the patch is unlikely to still apply cleanly.

Actions
Copy link

Also available in: PDF Atom