Feature #7508

Clean up some more calls to rb_intern()

Added by Charlie Somerville over 1 year ago. Updated 4 months ago.

[ruby-core:50552]
Status:Closed
Priority:Normal
Assignee:Charlie Somerville
Category:core
Target version:2.1.0

Description

Related to #7495, I cleaned up a few more calls to rb_intern, replacing some with IDs defined in id.h, and others with IDs interned once on initialization and then cached.

clean_up_rb_interns.patch Magnifier (16.1 KB) Charlie Somerville, 12/04/2012 06:54 PM

History

#1 Updated by Usaku NAKAMURA over 1 year ago

  • Category set to core
  • Status changed from Open to Assigned
  • Assignee set to Charlie Somerville
  • Target version set to 2.0.0

IMO, it's OK.
Does anyone have another opinion?

#2 Updated by Masaki Matsushita over 1 year ago

  • Tracker changed from Bug to Feature

#3 Updated by Charlie Somerville about 1 year ago

  • Target version changed from 2.0.0 to next minor

Whoops I forgot about this ticket.

I'll commit it soon.

#4 Updated by Koichi Sasada about 1 year ago

  • Target version changed from next minor to 2.1.0

I have an opinion.

I want to move all static IDs move to defs/id.def. I have no objection with this patch. But all of replace can be replaced after that.

What do you think about?

#5 Updated by Nobuyoshi Nakada 4 months ago

Why not idCmp and idPow in array.c?

#6 Updated by Charlie Somerville 4 months ago

  • Status changed from Assigned to Closed

nobu: I'll close this ticket - the patch is unlikely to still apply cleanly.

Also available in: Atom PDF