Project

General

Profile

Feature #7508

Clean up some more calls to rb_intern()

Added by charliesome (Charlie Somerville) about 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Target version:
[ruby-core:50552]

Description

Related to #7495, I cleaned up a few more calls to rb_intern, replacing some with IDs defined in id.h, and others with IDs interned once on initialization and then cached.

clean_up_rb_interns.patch (16.1 KB) clean_up_rb_interns.patch charliesome (Charlie Somerville), 12/04/2012 06:54 PM

History

#1 Updated by usa (Usaku NAKAMURA) almost 5 years ago

  • Category set to core
  • Status changed from Open to Assigned
  • Assignee set to charliesome (Charlie Somerville)
  • Target version set to 2.0.0

IMO, it's OK.
Does anyone have another opinion?

#2 Updated by Glass_saga (Masaki Matsushita) almost 5 years ago

  • Tracker changed from Bug to Feature

#3 [ruby-core:52342] Updated by charliesome (Charlie Somerville) almost 5 years ago

  • Target version changed from 2.0.0 to next minor

Whoops I forgot about this ticket.

I'll commit it soon.

#4 [ruby-core:52347] Updated by ko1 (Koichi Sasada) almost 5 years ago

  • Target version changed from next minor to 2.1.0

I have an opinion.

I want to move all static IDs move to defs/id.def. I have no objection with this patch. But all of replace can be replaced after that.

What do you think about?

#5 [ruby-core:59101] Updated by nobu (Nobuyoshi Nakada) almost 4 years ago

Why not idCmp and idPow in array.c?

#6 [ruby-core:59103] Updated by charliesome (Charlie Somerville) almost 4 years ago

  • Status changed from Assigned to Closed

nobu: I'll close this ticket - the patch is unlikely to still apply cleanly.

Also available in: Atom PDF