Project

General

Profile

Actions
Copy link
Like0

Feature #7508

closed

Clean up some more calls to rb_intern()

Added by Anonymous over 12 years ago. Updated over 11 years ago.

Status:
Closed
Assignee:
-
Target version:
2.1.0
[ruby-core:50552]

Description

Related to #7495, I cleaned up a few more calls to rb_intern, replacing some with IDs defined in id.h, and others with IDs interned once on initialization and then cached.

Files

clean_up_rb_interns.patch (16.1 KB) clean_up_rb_interns.patch Anonymous, 12/04/2012 06:54 PM
Like0Actions
Copy link
 #1

Updated by usa (Usaku NAKAMURA) over 12 years ago

  • Category set to core
  • Status changed from Open to Assigned
  • Target version set to 2.0.0
  • Assignee set to Anonymous

IMO, it's OK.
Does anyone have another opinion?

Like0Actions
Copy link
 #2

Updated by Glass_saga (Masaki Matsushita) about 12 years ago

  • Tracker changed from Bug to Feature
Like0Actions
Copy link
 #3 [ruby-core:52342]

Updated by Anonymous about 12 years ago

  • Target version changed from 2.0.0 to 2.6

Whoops I forgot about this ticket.

I'll commit it soon.

Like0Actions
Copy link
 #4 [ruby-core:52347]

Updated by ko1 (Koichi Sasada) about 12 years ago

  • Target version changed from 2.6 to 2.1.0

I have an opinion.

I want to move all static IDs move to defs/id.def. I have no objection with this patch. But all of replace can be replaced after that.

What do you think about?

Like0Actions
Copy link
 #5 [ruby-core:59101]

Updated by nobu (Nobuyoshi Nakada) over 11 years ago

Why not idCmp and idPow in array.c?

Like0Actions
Copy link
 #6 [ruby-core:59103]

Updated by Anonymous over 11 years ago

  • Status changed from Assigned to Closed

nobu: I'll close this ticket - the patch is unlikely to still apply cleanly.

Actions
Copy link
Like0

Also available in: Atom PDF