Bug #7618

TestGemDoctor failures

Added by Benoit Daloze over 1 year ago. Updated over 1 year ago.

[ruby-core:51114]
Status:Closed
Priority:Normal
Assignee:Eric Hodel
Category:lib
Target version:2.0.0
ruby -v:ruby 1.8.7 (2012-02-08 patchlevel 358) [x86_64-linux] Backport:

Description

I guess it has already been noticed as shown on RubyCI but here is the failure:

[1/5] TestGemDoctor#testdoctor = 0.02 s
1) Failure:
test
doctor(TestGemDoctor) [/home/eregon/prefix/src/ruby/test/rubygems/testgemdoctor.rb:64]:
--- expected
+++ actual
@@ -1,6 +1,6 @@
"Checking /home/eregon/prefix/src/ruby/tmp/test/testrubygems22593/gemhome
-Removed directory gems/b-2
Removed directory gems/c-2
+Removed directory gems/b-2
Removed file specifications/c-2.gemspec

"

[5/5] TestGemDoctor#testdoctordryrun = 0.03 s

2) Failure:
test
doctordryrun(TestGemDoctor) [/home/eregon/prefix/src/ruby/test/rubygems/testgemdoctor.rb:117]:
--- expected
+++ actual
@@ -1,6 +1,6 @@
"Checking /home/eregon/prefix/src/ruby/tmp/test/testrubygems22593/gemhome
-Extra directory gems/b-2
Extra directory gems/c-2
+Extra directory gems/b-2
Extra file specifications/c-2.gemspec

"

Associated revisions

Revision 38691
Added by Eric Hodel over 1 year ago

  • lib/rubygems/doctor.rb: Process directories in order in case the
    filesystem doesn't. [ruby-trunk - Bug #7618]

    Process specifications before other directories in case of bugs.

  • test/rubygems/testgemdoctor.rb: Test for above.

  • lib/rubygems.rb: Updated version.

  • test/rubygems/test_require.rb: Fixed double require of benchmark.rb.
    RubyGems bug #420.

  • test/rubygems/testgemcommandscheckcommand.rb: Fixed unused
    variable warnings.

  • test/rubygems/testgemcommandsquerycommand.rb: ditto

  • test/rubygems/testgeminstaller.rb: ditto

History

#1 Updated by Luis Lavena over 1 year ago

  • Status changed from Open to Assigned

#2 Updated by Eric Hodel over 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38691.
Benoit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/rubygems/doctor.rb: Process directories in order in case the
    filesystem doesn't. [ruby-trunk - Bug #7618]

    Process specifications before other directories in case of bugs.

  • test/rubygems/testgemdoctor.rb: Test for above.

  • lib/rubygems.rb: Updated version.

  • test/rubygems/test_require.rb: Fixed double require of benchmark.rb.
    RubyGems bug #420.

  • test/rubygems/testgemcommandscheckcommand.rb: Fixed unused
    variable warnings.

  • test/rubygems/testgemcommandsquerycommand.rb: ditto

  • test/rubygems/testgeminstaller.rb: ditto

Also available in: Atom PDF