Project

General

Profile

Bug #7744

Fix signed integer overflows Github #242

Added by zzak (Zachary Scott) over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
2.0.0
Backport:
[ruby-core:51711]

Description

=begin
From (()):

((Signed integer overflow is undefined behavior in C. Many compilers assume no signed integer overflows and even optimize away overflow checks. The -fno-strict-overflow flag works around this issue in gcc, but doesn't fix the fundamentally broken code.))

((This patchset fixes signed integer overflows in time.c, ossl.c, and bigdecimal.c.))

I've attached the associated patch.
=end


Files

242.patch (4.09 KB) 242.patch zzak (Zachary Scott), 01/28/2013 02:14 AM

Updated by ko1 (Koichi Sasada) over 7 years ago

  • Assignee set to nobu (Nobuyoshi Nakada)
  • Target version changed from 2.6 to 2.1.0
#2

Updated by nobu (Nobuyoshi Nakada) over 6 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r44395.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


ossl.c: integer overflow

  • ext/openssl/ossl.c (string2hex): fix signed integer overflow. [ruby-core:51711] [Bug #7744] [Fixes GH-242]

Also available in: Atom PDF