lost-tuple bug and fix for Rinda::TupleSpaceProxy.take
Rinda::TupleSpaceProxy prevents tuple loss during #take by exposing a "port" object on the client that the remote side (the tuplespace server) pushes to, instead of relying on the method return value. Pushing to the port fails if the process that called #take has exited, so the tuple will not be deleted from the tuplespace server.
However, if the process has not exited, and the thread that called #take was interrupted, the port still exists and accepts push requests (in the main drb thread). In this case the tuple is deleted on the server and not available on the client.
This is frequently a problem when using irb and manually interrupting take calls. It would also be a problem when using timeouts.
A concise reproduction of the problem is in the attached thread-int.rb.
The bug can be fixed by the patch below, which replaces the port array with a custom object that rejects pushes if the call stack has been unwound.
Note that this patch combines naturally with the faster take patch in #8119.
diff --git a/lib/rinda/rinda.rb b/lib/rinda/rinda.rb
index 18e284a..057c61a 100644
@@ -206,6 +206,23 @@ module Rinda
# TupleSpaceProxy allows a remote Tuplespace to appear as local.
- class Port
- attr_reader :val +
- def initialize
- @open = true
- def close
- @open = false
- end +
- def push val
- raise unless @open
- @val = val
- nil # so that val doesn't get marshalled again
# Creates a new TupleSpaceProxy to wrap +ts+.
@@ -222,6 +239,19 @@ module Rinda
# Safely takes +tuple+ from the proxied TupleSpace. See TupleSpace#take.
# Ensures that an interrupted thread will not become a lasting cause
# of further data loss.
def take_safely(tuple, sec=nil, &block)
port = Port.new
@ts.move(DRbObject.new(port), tuple, sec, &block)
port.close # don't let the DRb thread push to it when remote sends tuple
# Takes +tuple+ from the proxied TupleSpace. See TupleSpace#take.
def take(tuple, sec=nil, &block)
- lib/rinda/rinda.rb: Fixed loss of tuple when remote is alive but the call stack was unwound. Patch by Joel VanderWerf. [ruby-trunk - Bug #8125] * test/rinda/test_rinda.rb: Test for the above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- lib/rinda/tuplespace.rb: Only return tuple entry once on move, either through port or regular return, not both. This results in a 120% speedup when combined with #8125. Patch by Joel VanderWerf. [ruby-trunk - Feature #8119]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Updated by drbrain (Eric Hodel) about 6 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r39890.
Joel, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
- lib/rinda/rinda.rb: Fixed loss of tuple when remote is alive but the
call stack was unwound. Patch by Joel VanderWerf.
[ruby-trunk - Bug #8125]
- test/rinda/test_rinda.rb: Test for the above.