Backport #8209: mkmf.log contains misplaced messages

• Status: Closed
• Assignee: nagachika (Tomoyuki Chikanaga)

[akr (Akira Tanaka)]

mkmf.log の内容が奇妙なものになることがあります。

以下は Debian GNU/Linux squeeze でのビルドの結果から
調べたものですが、
ext/-test-/win32/dln の mkmf.log にその拡張ライブラリ以外 (tk とか win32ole
とか) に関するメッセージが出ています。
また、なぜ ext/-test-/win32/dln がビルドされないかという理由が残っていません。
同様に、tk の mkmf には win32ole に関するメッセージが入っていて、
なぜ tk がビルドされないかという理由が入っていません。

boron% cat ext/-test-/win32/dln/mkmf.log
Failed to configure -test-/win32/dln. It will not be installed.
Failed to configure -test-/win32/fd_setsize. It will not be installed.
Failed to configure dl/win32. It will not be installed.
Failed to configure fiddle/win32. It will not be installed.
Failed to configure tk. It will not be installed.
Failed to configure tk/tkutil. It will not be installed.
Failed to configure win32ole. It will not be installed.
boron% cat ext/tk/mkmf.log
Failed to configure tk. It will not be installed.
Failed to configure tk/tkutil. It will not be installed.
Failed to configure win32ole. It will not be installed.

boron% pwd
/home/akr/chkbuild/tmp/build/ruby-trunk/20130403T000400Z/ruby
boron% svn info
Path: .
URL: http://svn.ruby-lang.org/repos/ruby/trunk
Repository Root: http://svn.ruby-lang.org/repos/ruby
Repository UUID: b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Revision: 40075
Node Kind: directory
Schedule: normal
Last Changed Author: svn
Last Changed Rev: 40073
Last Changed Date: 2013-04-03 00:09:41 +0900 (Wed, 03 Apr 2013)

なお、気がついたきっかけは socket をいじったときで、
ext/-test-/win32/dln や ext/tk 固有の問題ではないと思います。

[akr (Akira Tanaka)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r40080.
Akira, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• ext/extmk.rb (extmake): Use Logging.open to switch stdout and
  stderr. Delay Logging::log_close until the failure message is
  written. Write the failure message only if log file is opened.

• lib/mkmf.rb (Logging.log_opened?): New method.

  [ruby-dev:47215] [Bug #8209]

[nagachika (Tomoyuki Chikanaga)]

• Tracker changed from Bug to Backport
• Project changed from Ruby to 15
• Status changed from Closed to Assigned
• Assignee set to nagachika (Tomoyuki Chikanaga)

[nagachika (Tomoyuki Chikanaga)]

• Status changed from Assigned to Closed

This issue was solved with changeset r42359.
Akira, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

merge revision(s) 40080,40081: [Backport #8209]

* ext/extmk.rb (extmake): Use Logging.open to switch stdout and
  stderr.  Delay Logging::log_close until the failure message is
  written.  Write the failure message only if log file is opened.

* lib/mkmf.rb (Logging.log_opened?): New method.
  [ruby-dev:47215] [Bug #8209]

* ext/extmk.rb (extmake): Invoke Logging::log_close in a ensure
  clause.