Bug #825

Gem::Installer#generate_windows_script の引数の順番が他と一致しない

Added by okkez _ over 6 years ago. Updated about 4 years ago.

Status:Closed
Priority:Urgent
Assignee:Eric Hodel
ruby -v:ruby 1.9.2dev (2009-11-09 trunk 25701) [x86_64-freebsd8.0] Backport:

Description

=begin
一つだけ引数の順番が異なるのは、混乱するので
Gem::Installer#generate_bin_script, Gem::Installer#generate_bin_symlink
と引数の順番を合わせました。

Index: lib/rubygems/installer.rb
===================================================================
--- lib/rubygems/installer.rb (revision 20439)
+++ lib/rubygems/installer.rb (working copy)
@@ -292,7 +292,7 @@
##
# Creates windows .bat files for easy running of commands

  • def generate_windows_script(bindir, filename)
  • def generate_windows_script(filename, bindir)
    if Gem.win_platform? then
    script_name = filename + ".bat"
    script_path = File.join bindir, File.basename(script_name)
    @@ -351,7 +351,7 @@

    say bin_script_path if Gem.configuration.really_verbose
    
  •  generate_windows_script bindir, filename
    
  •  generate_windows_script filename, bindir
    

    #else
    # FileUtils.rm_f bin_script_path
    # FileUtils.cp exec_path, bin_script_path,
    =end

History

#1 Updated by Koichi Sasada over 6 years ago

  • Assignee set to Eric Hodel

=begin

=end

#2 Updated by Yuki Sonoda over 6 years ago

  • Target version set to 2.0.0

=begin

=end

#3 Updated by Yui NARUSE over 5 years ago

  • Status changed from Open to Assigned
  • ruby -v set to ruby 1.9.2dev (2009-11-09 trunk 25701) [x86_64-freebsd8.0]

=begin
He says:
Gem::Installer#generate_windows_script has different argument's order from Gem::Installer#generate_bin_script, Gem::Installer#generate_bin_symlink.
So generate_windows_script should change its argument order.
=end

#4 Updated by Yui NARUSE over 5 years ago

  • Priority changed from Normal to Urgent

=begin

=end

#5 Updated by Eric Hodel about 5 years ago

=begin
I have applied this patch to RubyGems trunk.
=end

#6 Updated by Eric Hodel about 5 years ago

  • Status changed from Assigned to Closed

=begin
Appled r27441
=end

Also available in: Atom PDF