Project

General

Profile

Actions

Backport #8645

closed

URI#find_proxy failure if scheme is nil

Added by djberg96 (Daniel Berger) over 11 years ago. Updated over 11 years ago.


Description

If the URI scheme is not present after a URI.parse call, the call to URI#find_proxy fails.

require 'uri'
u = URI.parse("ruby-lang.org")
u.find_proxy

The result is:

c:/ruby2/lib/ruby/2.0.0/uri/generic.rb:1614:in find_proxy': undefined method downcase' for nil:NilClass (NoMethodError)

This actually happens in 1.9.x as well.

I'm not sure what it should return in this case, but it shouldn't raise that error.

Actions #1

Updated by naruse (Yui NARUSE) over 11 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r42153.
Daniel, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/uri/generic.rb (find_proxy): raise BadURIError if the URI is
    a relative URI. [Bug #8645]
Actions #2

Updated by nagachika (Tomoyuki Chikanaga) over 11 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport200
  • Status changed from Closed to Assigned
  • Assignee set to nagachika (Tomoyuki Chikanaga)
Actions #3

Updated by nagachika (Tomoyuki Chikanaga) over 11 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r42155.
Daniel, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 42153: [Backport #8645]

* lib/uri/generic.rb (find_proxy): raise BadURIError if the URI is
  a relative URI. [Bug #8645]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0