Bug #9051

open-uri meta_add_field method removed

Added by Eamonn Webster 6 months ago. Updated 6 months ago.

[ruby-core:58017]
Status:Closed
Priority:Normal
Assignee:Akira Tanaka
Category:lib
Target version:2.1.0
ruby -v:ruby 2.1.0dev (2013-10-18 trunk 43355) [x86_64-darwin12.5.0] Backport:1.9.3: DONTNEED, 2.0.0: DONTNEED

Description

In the fix for bug #4964 the method Meta#metaaddfield(name, value) was removed and replaced with metaaddfield2(name, values) Note plural!

This breaks code that uses metaaddfield. e.g. HTTPClient.

The fix is to re-implement metaaddfield using metaaddfield2

0001-removing-meta_add_field-breaks-stuff.patch Magnifier (729 Bytes) Eamonn Webster, 10/24/2013 09:43 PM

Associated revisions

Revision 43430
Added by Akira Tanaka 6 months ago

  • lib/open-uri.rb (metaaddfield): : Re-implemented. [Bug #9051] patch by Eamonn Webster.

History

#1 Updated by Yui NARUSE 6 months ago

  • Category set to lib
  • Status changed from Open to Assigned
  • Assignee set to Akira Tanaka
  • Target version set to 2.1.0
  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: DONTNEED, 2.0.0: DONTNEED

Sounds reasonable.
How do you think, akr?

#2 Updated by Akira Tanaka 6 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43430.
Eamonn, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/open-uri.rb (metaaddfield): : Re-implemented. [Bug #9051] patch by Eamonn Webster.

Also available in: Atom PDF