Bug #9187

st_table leaks when exception is raised in Hash#rehash

Added by Masaki Matsushita over 1 year ago. Updated about 1 year ago.

[ruby-core:58728]
Status:Closed
Priority:Normal
Assignee:Masaki Matsushita
ruby -v:ruby 2.1.0dev (2013-12-01 trunk 43941) [x86_64-linux] Backport:1.9.3: DONE, 2.0.0: DONE

Description

Following code causes leakage of st_table:

class Foo
  def initialize
    @raise = false
  end

  def hash
    raise if @raise
    @raise = true
    return 0
  end
end

h = {Foo.new => true}
10_0000.times do
  h.rehash rescue nil
end

Associated revisions

Revision 43942
Added by glass over 1 year ago

  • hash.c (rb_hash_rehash): fix to free new st_table when exception is raised in do_hash(). [Bug #9187]

Revision 43942
Added by glass over 1 year ago

  • hash.c (rb_hash_rehash): fix to free new st_table when exception is raised in do_hash(). [Bug #9187]

Revision 43957
Added by glass over 1 year ago

  • hash.c (rb_hash_rehash): make temporary st_table under the control
    of GC. [Bug #9187]

  • test/ruby/test_hash.rb: add a test for above.

Revision 43957
Added by glass over 1 year ago

  • hash.c (rb_hash_rehash): make temporary st_table under the control
    of GC. [Bug #9187]

  • test/ruby/test_hash.rb: add a test for above.

Revision 43975
Added by glass over 1 year ago

  • array.c (rb_hash_rehash): use hash_alloc() instead of rb_hash_new(). [Bug #9187]

Revision 43975
Added by glass over 1 year ago

  • array.c (rb_hash_rehash): use hash_alloc() instead of rb_hash_new(). [Bug #9187]

History

#1 Updated by Anonymous over 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43942.
Masaki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • hash.c (rb_hash_rehash): fix to free new st_table when exception is raised in do_hash(). [Bug #9187]

#2 Updated by Usaku NAKAMURA about 1 year ago

  • Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED to 1.9.3: DONE, 2.0.0: REQUIRED

backported into ruby_1_9_3 at r44948.

#3 Updated by Tomoyuki Chikanaga about 1 year ago

  • Backport changed from 1.9.3: DONE, 2.0.0: REQUIRED to 1.9.3: DONE, 2.0.0: DONE

r43942, r43957 and r43975 were backported to ruby_2_0_0 at r45011.

#4 Updated by Nobuyoshi Nakada about 1 year ago

  • Description updated (diff)

Also available in: Atom PDF