Bug #9195

r43951 raised many test failures of TestProcess and TestEnv on vc10-x64-trunk

Added by Heesob Park 5 months ago. Updated 5 months ago.

[ruby-core:58779]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA
Category:-
Target version:-
ruby -v:ruby 2.1.0dev (2013-12-02 trunk 43952) [x64-mswin64_120] Backport:1.9.3: UNKNOWN, 2.0.0: UNKNOWN

Description

It seems that r43951 caused side effect of ENV handling.
After r43951, I can see 13 failures and 1 error which are related with ENV.

Here is somes test failures from http://ruby-mswin.cloudapp.net/vc10-x64/ruby-trunk/log/20131202T011551Z.log.html.gz

110) Failure:
TestProcess#testexecoptsunsetenvothers [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testprocess.rb:386]:
<""> expected but was
<"GEMRC=\nGEMSKIP=\nhmm=\nRUBYGEMSGEMDEPS=\n">.

111) Failure:
TestProcess#testexecoptsenvpopenvector [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testprocess.rb:327]:
["D:/tmp/mswin-build20131202-6328-161zivw/ruby/ruby.exe", "-e", "%w[RUBYLIB HOME USER TMPDIR].each{|e|ENV.delete(e)}", "-e", "ENV.each {|k,v| puts \"#{k}=#{v}\" }"].
Expected /hmm=/ to not match "ALLUSERSPROFILE=C:\ProgramData\nAPPDATA=C:\Users\usa\AppData\Roaming\nCommandPromptType=Native\nCommonProgramFiles=C:\Program Files\Common Files\nCommonProgramFiles(x86)=C:\Program Files (x86)\Common Files\nCommonProgramW6432=C:\Program Files\Common Files\nCOMPUTERNAME=RUBY-MSWIN\nComSpec=C:\Windows\system32\cmd.exe\nCYGWIN=nodosfilewarning\nFP
NOHOSTCHECK=NO\nFramework35Version=v3.5\nFrameworkDir=C:\Windows\Microsoft.NET\Framework64\nFrameworkDIR64=C:\Windows\Microsoft.NET\Framework64\nFrameworkVersion=v4.0.30319\nFrameworkVersion64=v4.0.30319\nGEMRC=\nGEMSKIP=\nGEMSPECCACHE=D:/tmp/testrubygems2816/speccache\nhmm=\nhttpsproxy=http://localhost:1234\nHTTPCOOKIE2=name2=val2\nINCLUDE=D:\libraries\include;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include;\nLIB=D:\libraries\lib;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\LIB\amd64;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\LIB\amd64;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\lib\x64;\nLIBPATH=C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Windows\Microsoft.NET\Framework64\v3.5;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\LIB\amd64;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\LIB\amd64;\nLOCALAPPDATA=C:\Users\usa\AppData\Local\nMAKEDIR=D:\tmp\mswin-build20131202-6328-161zivw\ruby\nMAKEFLAGS= \nNUMBEROFPROCESSORS=2\nOS=WindowsNT\nPATH=D:/tmp/mswin-build20131202-6328-161zivw/ruby;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\amd64;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Windows\Microsoft.NET\Framework64\v3.5;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\IDE;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\Tools;C:\Program Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Team Tools\Performance Tools\x64;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Team Tools\Performance Tools;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin\NETFX 4.0 Tools\x64;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin\x64;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin;D:\ruby-2.0.0-p247-vc10-x64\bin;D:\libraries\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;D:\cygwin\bin\nPATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC\nPlatform=mswin64100\nPROCESSORARCHITECTURE=x64\nPROCESSORIDENTIFIER=AMD64 Family 16 Model 8 Stepping 1, AuthenticAMD\nPROCESSORLEVEL=16\nPROCESSORREVISION=0801\nProgramData=C:\ProgramData\nProgramFiles=C:\Program Files\nProgramFiles(x86)=C:\Program Files (x86)\nProgramW6432=C:\Program Files\nPROMPT=$P$G\nPSModulePath=C:\Windows\system32\WindowsPowerShell\v1.0\Modules\\nPUBLIC=C:\Users\Public\nRDOCTEST=yes\nRUBY=D:/tmp/mswin-build20131202-6328-161zivw/ruby/ruby.exe\nRUBYGEMSGEMDEPS=\nRUBYOPT=-w\nSERVERPORT=8080\nSystemDrive=C:\nSystemRoot=C:\Windows\nTEMP=D:\tmp\nTESTS=-v\nTMP=D:\tmp\nUSERDOMAIN=RUBY-MSWIN\nUSERNAME=usa\nUSERPROFILE=C:\Users\usa\nVCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\\nVS100COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\Tools\\nVSINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio 10.0\\nwindir=C:\Windows\nWindowsSdkDir=C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\\nwindowstracingflags=3\nwindowstracinglogfile=C:\BVTBin\Tests\installpackage\csilogfile.log\nNMAKE_VER=10.00.30319.01\n".

112) Failure:
TestProcess#testexecoptsenvpopenstring [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testprocess.rb:327]:
"D:/tmp/mswin-build20131202-6328-161zivw/ruby/ruby.exe test-script".
Expected /hmm=/ to not match "ALLUSERSPROFILE=C:\ProgramData\nAPPDATA=C:\Users\usa\AppData\Roaming\nCommandPromptType=Native\nCommonProgramFiles=C:\Program Files\Common Files\nCommonProgramFiles(x86)=C:\Program Files (x86)\Common Files\nCommonProgramW6432=C:\Program Files\Common Files\nCOMPUTERNAME=RUBY-MSWIN\nComSpec=C:\Windows\system32\cmd.exe\nCYGWIN=nodosfilewarning\nFP
NOHOSTCHECK=NO\nFramework35Version=v3.5\nFrameworkDir=C:\Windows\Microsoft.NET\Framework64\nFrameworkDIR64=C:\Windows\Microsoft.NET\Framework64\nFrameworkVersion=v4.0.30319\nFrameworkVersion64=v4.0.30319\nGEMRC=\nGEMSKIP=\nGEMSPECCACHE=D:/tmp/testrubygems2816/speccache\nhmm=\nhttpsproxy=http://localhost:1234\nHTTPCOOKIE2=name2=val2\nINCLUDE=D:\libraries\include;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include;\nLIB=D:\libraries\lib;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\LIB\amd64;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\LIB\amd64;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\lib\x64;\nLIBPATH=C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Windows\Microsoft.NET\Framework64\v3.5;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\LIB\amd64;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\LIB\amd64;\nLOCALAPPDATA=C:\Users\usa\AppData\Local\nMAKEDIR=D:\tmp\mswin-build20131202-6328-161zivw\ruby\nMAKEFLAGS= \nNUMBEROFPROCESSORS=2\nOS=WindowsNT\nPATH=D:/tmp/mswin-build20131202-6328-161zivw/ruby;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\amd64;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Windows\Microsoft.NET\Framework64\v3.5;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\IDE;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\Tools;C:\Program Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Team Tools\Performance Tools\x64;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Team Tools\Performance Tools;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin\NETFX 4.0 Tools\x64;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin\x64;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin;D:\ruby-2.0.0-p247-vc10-x64\bin;D:\libraries\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;D:\cygwin\bin\nPATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC\nPlatform=mswin64100\nPROCESSORARCHITECTURE=x64\nPROCESSORIDENTIFIER=AMD64 Family 16 Model 8 Stepping 1, AuthenticAMD\nPROCESSORLEVEL=16\nPROCESSORREVISION=0801\nProgramData=C:\ProgramData\nProgramFiles=C:\Program Files\nProgramFiles(x86)=C:\Program Files (x86)\nProgramW6432=C:\Program Files\nPROMPT=$P$G\nPSModulePath=C:\Windows\system32\WindowsPowerShell\v1.0\Modules\\nPUBLIC=C:\Users\Public\nRDOCTEST=yes\nRUBY=D:/tmp/mswin-build20131202-6328-161zivw/ruby/ruby.exe\nRUBYGEMSGEMDEPS=\nRUBYOPT=-w\nSERVERPORT=8080\nSystemDrive=C:\nSystemRoot=C:\Windows\nTEMP=D:\tmp\nTESTS=-v\nTMP=D:\tmp\nUSERDOMAIN=RUBY-MSWIN\nUSERNAME=usa\nUSERPROFILE=C:\Users\usa\nVCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\\nVS100COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\Tools\\nVSINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio 10.0\\nwindir=C:\Windows\nWindowsSdkDir=C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\\nwindowstracingflags=3\nwindowstracinglogfile=C:\BVTBin\Tests\installpackage\csilogfile.log\nNMAKE_VER=10.00.30319.01\n".

113) Failure:
TestProcess#testexecoptsenv [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testprocess.rb:302]:
Expected /hmm=/ to not match "ALLUSERSPROFILE=C:\ProgramData\nAPPDATA=C:\Users\usa\AppData\Roaming\nCommandPromptType=Native\nCommonProgramFiles=C:\Program Files\Common Files\nCommonProgramFiles(x86)=C:\Program Files (x86)\Common Files\nCommonProgramW6432=C:\Program Files\Common Files\nCOMPUTERNAME=RUBY-MSWIN\nComSpec=C:\Windows\system32\cmd.exe\nCYGWIN=nodosfilewarning\nFP
NOHOSTCHECK=NO\nFramework35Version=v3.5\nFrameworkDir=C:\Windows\Microsoft.NET\Framework64\nFrameworkDIR64=C:\Windows\Microsoft.NET\Framework64\nFrameworkVersion=v4.0.30319\nFrameworkVersion64=v4.0.30319\nGEMRC=\nGEMSKIP=\nGEMSPECCACHE=D:/tmp/testrubygems2816/speccache\nhmm=\nhttpsproxy=http://localhost:1234\nHTTPCOOKIE2=name2=val2\nINCLUDE=D:\libraries\include;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\include;\nLIB=D:\libraries\lib;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\LIB\amd64;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\LIB\amd64;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\lib\x64;\nLIBPATH=C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Windows\Microsoft.NET\Framework64\v3.5;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\LIB\amd64;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\ATLMFC\LIB\amd64;\nLOCALAPPDATA=C:\Users\usa\AppData\Local\nMAKEDIR=D:\tmp\mswin-build20131202-6328-161zivw\ruby\nMAKEFLAGS= \nNUMBEROFPROCESSORS=2\nOS=WindowsNT\nPATH=D:/tmp/mswin-build20131202-6328-161zivw/ruby;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\amd64;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Windows\Microsoft.NET\Framework64\v3.5;C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\IDE;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\Tools;C:\Program Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Team Tools\Performance Tools\x64;C:\Program Files (x86)\Microsoft Visual Studio 10.0\Team Tools\Performance Tools;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin\NETFX 4.0 Tools\x64;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin\x64;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin;D:\ruby-2.0.0-p247-vc10-x64\bin;D:\libraries\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;D:\cygwin\bin\nPATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC\nPlatform=mswin64100\nPROCESSORARCHITECTURE=x64\nPROCESSORIDENTIFIER=AMD64 Family 16 Model 8 Stepping 1, AuthenticAMD\nPROCESSORLEVEL=16\nPROCESSORREVISION=0801\nProgramData=C:\ProgramData\nProgramFiles=C:\Program Files\nProgramFiles(x86)=C:\Program Files (x86)\nProgramW6432=C:\Program Files\nPROMPT=$P$G\nPSModulePath=C:\Windows\system32\WindowsPowerShell\v1.0\Modules\\nPUBLIC=C:\Users\Public\nRDOCTEST=yes\nRUBY=D:/tmp/mswin-build20131202-6328-161zivw/ruby/ruby.exe\nRUBYGEMSGEMDEPS=\nRUBYOPT=-w\nSERVERPORT=8080\nSystemDrive=C:\nSystemRoot=C:\Windows\nTEMP=D:\tmp\nTESTS=-v\nTMP=D:\tmp\nUSERDOMAIN=RUBY-MSWIN\nUSERNAME=usa\nUSERPROFILE=C:\Users\usa\nVCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\\nVS100COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\Tools\\nVSINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio 10.0\\nwindir=C:\Windows\nWindowsSdkDir=C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\\nwindowstracingflags=3\nwindowstracinglogfile=C:\BVTBin\Tests\installpackage\csilogfile.log\nNMAKE_VER=10.00.30319.01\n".

114) Failure:
TestEnv#testclear [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testenv.rb:224]:
expected but was
.

115) Failure:
TestEnv#testupdate [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testenv.rb:342]:
<[["A", "B"],
["BAZ", "QUUX"],
["FOO", "BAR"],
["GEMHOME", ""],
["GEM
PATH", ""],
["GEM_SKIP", ""]]> expected but was
<[["A", "B"], ["BAZ", "QUUX"], ["FOO", "BAR"]]>.

116) Failure:
TestEnv#testtoa [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/test_env.rb:249]:
expected but was
.

117) Failure:
TestEnv#testemptyp [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testenv.rb:270]:
Expected {"GEM
HOME"=>nil, "GEMPATH"=>nil, "GEMSKIP"=>nil} to be empty?.

118) Failure:
TestEnv#testreplace [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testenv.rb:342]:
<[["BAZ", "QUX"],
["FOO", "BAR"],
["GEMHOME", ""],
["GEM
PATH", ""],
["GEM_SKIP", ""]]> expected but was
<[["BAZ", "QUX"], ["FOO", "BAR"]]>.

119) Failure:
TestEnv#testinvert [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testenv.rb:342]:
<[["", "GEM_SKIP"], ["BAR", "FOO"], ["QUX", "BAZ"]]> expected but was
<[["BAR", "FOO"], ["QUX", "BAZ"]]>.

120) Failure:
TestEnv#testinspect [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testenv.rb:238]:
Failed assertion, no message given.

121) Failure:
TestEnv#testgetenv [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testenv.rb:98]:
<""> expected but was
.

122) Failure:
TestEnv#testshift [D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/testenv.rb:352]:
Expected ["GEM_HOME", nil] to be nil.

123) Error:
TestEnv#testfetch:
KeyError: key not found: "PATH"
D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/test
env.rb:116:in fetch'
D:/tmp/mswin-build20131202-6328-161zivw/ruby/test/ruby/test_env.rb:116:in
test_fetch'

Interestingly, These failures are not found with MingW64 gcc compiler build version.

Associated revisions

Revision 43958
Added by Usaku NAKAMURA 5 months ago

  • hash.c (getenv): fixed test failures introduced by r43950. [Bug #9195] reported by phasis68 (Heesob Park).

History

#1 Updated by Hiroshi SHIBATA 5 months ago

  • Assignee set to Usaku NAKAMURA

phasis68

r43951 is only bump version. Can you investigate broken commit?

#2 Updated by Heesob Park 5 months ago

Sorry, The revision is r43950, not r43951.

#3 Updated by Usaku NAKAMURA 5 months ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43958.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • hash.c (getenv): fixed test failures introduced by r43950. [Bug #9195] reported by phasis68 (Heesob Park).

Also available in: Atom PDF