Bug #9351

Make Rinda::RingFinger work correctly on OpenBSD and NetBSD

Added by Jeremy Evans over 1 year ago. Updated about 1 year ago.

[ruby-core:59497]
Status:Closed
Priority:Normal
Assignee:Masatoshi Seki
ruby -v:ruby 2.1.0p0 (2013-12-25 revision 44422) [x86_64-openbsd] Backport:1.9.3: DONTNEED, 2.0.0: DONTNEED, 2.1: DONE

Description

The current Rinda::RingFinger code assumes that the IP_MULTICAST_LOOP socket option takes int, but in NetBSD and OpenBSD it takes unsigned char. Switch to using Socket::Option.ipv4_multicast_loop for better portability.

To get this to work correctly on OpenBSD, the patch in #9350 is required.

patch-lib_rinda_ring_rb (532 Bytes) Jeremy Evans, 01/03/2014 01:38 PM

Associated revisions

Revision 44492
Added by Eric Hodel over 1 year ago

  • lib/rinda/ring.rb (Rinda::RingFinger#make_socket): Use ipv4_multicast_loop option for portability. Patch by Jeremy Evans. [ruby-trunk - Bug #9351]

Revision 44492
Added by Eric Hodel over 1 year ago

  • lib/rinda/ring.rb (Rinda::RingFinger#make_socket): Use ipv4_multicast_loop option for portability. Patch by Jeremy Evans. [ruby-trunk - Bug #9351]

History

#1 Updated by Eric Hodel over 1 year ago

  • Category set to lib
  • Status changed from Open to Assigned
  • Assignee set to Masatoshi Seki
  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN to 1.9.3: DONTNEED, 2.0.0: DONTNEED, 2.1: REQUIRED

#2 Updated by Eric Hodel over 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r44492.
Jeremy, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/rinda/ring.rb (Rinda::RingFinger#make_socket): Use ipv4_multicast_loop option for portability. Patch by Jeremy Evans. [ruby-trunk - Bug #9351]

#3 Updated by Yui NARUSE about 1 year ago

  • Backport changed from 1.9.3: DONTNEED, 2.0.0: DONTNEED, 2.1: REQUIRED to 1.9.3: DONTNEED, 2.0.0: DONTNEED, 2.1: DONE

Also available in: Atom PDF