Bug #9767

test-all parallel fails if a test is skipped after raise

Added by Hiroshi Shirosaki 10 months ago. Updated 6 months ago.

[ruby-core:62133]
Status:Closed
Priority:Normal
Assignee:-
ruby -v:ruby 2.2.0dev (2014-04-15 trunk 45590) [i386-mingw32] Backport:2.0.0: DONE, 2.1: DONE

Description

DL::TestFunc#test_sinf is skipped after raise on mingw ruby.

But it causes Mashal.load failure due to undefined class/module
DL::DLError when doing test-all parallel and test-all doesn't
complete.

We create new MiniTest::Skip object to avoid Mashal.load
failure. I added a test for the bug.

0001-test-all-parallel-fails-if-a-test-is-skipped-after-r.patch Magnifier (3.27 KB) Hiroshi Shirosaki, 04/22/2014 09:42 AM

Associated revisions

Revision 45953
Added by shirosaki 10 months ago

parallel.rb: fix test-all parallel failure

  • lib/test/unit/parallel.rb: fix test-all parallel failure if a test
    is skipped after raise.
    DL::TestFunc#test_sinf is skipped after raise on mingw ruby.
    But it causes Mashal.load failure due to undefined class/module
    DL::DLError when doing test-all parallel and test-all doesn't
    complete. We create new MiniTest::Skip object to avoid Mashal.load
    failure.
    [Bug #9767]

  • test/testunit/test_parallel.rb (TestParallel): add a test.

  • test/testunit/tests_for_parallel/ptest_forth.rb: ditto.

Revision 45953
Added by shirosaki 10 months ago

parallel.rb: fix test-all parallel failure

  • lib/test/unit/parallel.rb: fix test-all parallel failure if a test
    is skipped after raise.
    DL::TestFunc#test_sinf is skipped after raise on mingw ruby.
    But it causes Mashal.load failure due to undefined class/module
    DL::DLError when doing test-all parallel and test-all doesn't
    complete. We create new MiniTest::Skip object to avoid Mashal.load
    failure.
    [Bug #9767]

  • test/testunit/test_parallel.rb (TestParallel): add a test.

  • test/testunit/tests_for_parallel/ptest_forth.rb: ditto.

Revision 46916
Added by Tomoyuki Chikanaga 7 months ago

merge revision(s) r45953,r45961: [Backport #9767]

* lib/test/unit/parallel.rb: fix test-all parallel failure if a test
  is skipped after raise.
  DL::TestFunc#test_sinf is skipped after raise on mingw ruby.
  But it causes Mashal.load failure due to undefined class/module
  DL::DLError when doing test-all parallel and test-all doesn't
  complete. We create new MiniTest::Skip object to avoid Mashal.load
  failure.
   [Bug #9767]

* test/testunit/test_parallel.rb (TestParallel): add a test.

* test/testunit/tests_for_parallel/ptest_forth.rb: ditto.
  But it causes Marshal.load failure due to undefined class/module
  complete. We create new MiniTest::Skip object to avoid Marshal.load

Revision 47338
Added by Usaku NAKAMURA 6 months ago

merge revision(s) 45953,45961: [Backport #9767]

* lib/test/unit/parallel.rb: fix test-all parallel failure if a test
  is skipped after raise.
  DL::TestFunc#test_sinf is skipped after raise on mingw ruby.
  But it causes Mashal.load failure due to undefined class/module
  DL::DLError when doing test-all parallel and test-all doesn't
  complete. We create new MiniTest::Skip object to avoid Mashal.load
  failure.
   [Bug #9767]

* test/testunit/test_parallel.rb (TestParallel): add a test.

* test/testunit/tests_for_parallel/ptest_forth.rb: ditto.
  But it causes Marshal.load failure due to undefined class/module
  complete. We create new MiniTest::Skip object to avoid Marshal.load

History

#1 Updated by Anonymous 10 months ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r45953.


parallel.rb: fix test-all parallel failure

  • lib/test/unit/parallel.rb: fix test-all parallel failure if a test
    is skipped after raise.
    DL::TestFunc#test_sinf is skipped after raise on mingw ruby.
    But it causes Mashal.load failure due to undefined class/module
    DL::DLError when doing test-all parallel and test-all doesn't
    complete. We create new MiniTest::Skip object to avoid Mashal.load
    failure.
    [Bug #9767]

  • test/testunit/test_parallel.rb (TestParallel): add a test.

  • test/testunit/tests_for_parallel/ptest_forth.rb: ditto.

#2 Updated by Usaku NAKAMURA 8 months ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN to 2.0.0: REQUIRED, 2.1: REQUIRED

#3 Updated by Tomoyuki Chikanaga 7 months ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE

Backported into ruby_2_1 branch at r46916.

#4 Updated by Usaku NAKAMURA 6 months ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: DONE to 2.0.0: DONE, 2.1: DONE

backported into ruby_2_0_0 at r47338.

Also available in: Atom PDF