Project

General

Profile

Bug #9856

[PATCH] process.c (proc_getgroups, proc_setgroups): use ALLOCV_N

Added by normalperson (Eric Wong) about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 2.2.0dev (2014-05-19 trunk 46010) [x86_64-linux]
[ruby-core:62694]

Description

On my Linux system, these may return up to 64K rb_gid_t entries for
a total of 256K stack usage, potentially triggering SystemStackError
or just a segfault. Use ALLOCV_N for stack safety, especially since
these are not performance-critical methods.

Will commit in a day or two.

http://bogomips.org/ruby.git/patch?id=9074e3808d


Files

process-allocv_n.patch (1.92 KB) process-allocv_n.patch normalperson (Eric Wong), 05/20/2014 02:17 AM

Associated revisions

Revision d450229a
Added by normal about 5 years ago

process.c (proc_getgroups, proc_setgroups): use ALLOCV_N

  • process.c (proc_getgroups, proc_setgroups): use ALLOCV_N [Bug #9856]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 46075
Added by normal about 5 years ago

process.c (proc_getgroups, proc_setgroups): use ALLOCV_N

  • process.c (proc_getgroups, proc_setgroups): use ALLOCV_N [Bug #9856]

Revision 46075
Added by normalperson (Eric Wong) about 5 years ago

process.c (proc_getgroups, proc_setgroups): use ALLOCV_N

  • process.c (proc_getgroups, proc_setgroups): use ALLOCV_N [Bug #9856]

Revision 46075
Added by normal about 5 years ago

process.c (proc_getgroups, proc_setgroups): use ALLOCV_N

  • process.c (proc_getgroups, proc_setgroups): use ALLOCV_N [Bug #9856]

Revision 46075
Added by normal about 5 years ago

process.c (proc_getgroups, proc_setgroups): use ALLOCV_N

  • process.c (proc_getgroups, proc_setgroups): use ALLOCV_N [Bug #9856]

Revision 46075
Added by normal about 5 years ago

process.c (proc_getgroups, proc_setgroups): use ALLOCV_N

  • process.c (proc_getgroups, proc_setgroups): use ALLOCV_N [Bug #9856]

Revision 46075
Added by normal about 5 years ago

process.c (proc_getgroups, proc_setgroups): use ALLOCV_N

  • process.c (proc_getgroups, proc_setgroups): use ALLOCV_N [Bug #9856]

Revision 1c8500b3
Added by usa (Usaku NAKAMURA) almost 5 years ago

merge revision(s) 46075: [Backport #9856]

    * process.c (proc_getgroups, proc_setgroups): use ALLOCV_N
      [Bug #9856]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@46581 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 46581
Added by usa (Usaku NAKAMURA) almost 5 years ago

merge revision(s) 46075: [Backport #9856]

* process.c (proc_getgroups, proc_setgroups): use ALLOCV_N
  [Bug #9856]

Revision 39d96342
Added by nagachika (Tomoyuki Chikanaga) almost 5 years ago

merge revision(s) r46075: [Backport #9856]

    * process.c (proc_getgroups, proc_setgroups): use ALLOCV_N
      [Bug #9856]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@46615 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 46615
Added by nagachika (Tomoyuki Chikanaga) almost 5 years ago

merge revision(s) r46075: [Backport #9856]

* process.c (proc_getgroups, proc_setgroups): use ALLOCV_N
  [Bug #9856]

History

#1

Updated by Anonymous about 5 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r46075.


process.c (proc_getgroups, proc_setgroups): use ALLOCV_N

  • process.c (proc_getgroups, proc_setgroups): use ALLOCV_N [Bug #9856]

Updated by usa (Usaku NAKAMURA) almost 5 years ago

  • Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED to 2.0.0: DONE, 2.1: REQUIRED

backported into ruby_2_0_0 at r46581.

Updated by nagachika (Tomoyuki Chikanaga) almost 5 years ago

  • Backport changed from 2.0.0: DONE, 2.1: REQUIRED to 2.0.0: DONE, 2.1: DONE

Backported into ruby_2_1 branch at r46615.

Also available in: Atom PDF