Project

General

Profile

Feature #10057

[PATCH] Add tests for Matrix class.

Added by gogo tanaka over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
[ruby-core:63809]

Description

I send 7 patches.

In one of patches (reorder_Matrix#real_and_Matrix_imaginary.patch), I just reorder methods.

I think Matrix#real should be upon Matrix#imaginary(From what I see complex.c)

In the others(6 patches), I add tests for Matrix class.

add_test_for_Matrix#eigensystem.patch View (594 Bytes) gogo tanaka, 07/18/2014 05:47 AM

add_test_for_Matrix#lup.patch View (644 Bytes) gogo tanaka, 07/18/2014 05:47 AM

add_test_for_Matrix#conjugate.patch View (775 Bytes) gogo tanaka, 07/18/2014 05:47 AM

add_test_for_Matrix#real.patch View (504 Bytes) gogo tanaka, 07/18/2014 05:47 AM

add_test_for_Matrix#imaginary.patch View (485 Bytes) gogo tanaka, 07/18/2014 05:47 AM

add_test_for_Matrix#rect.patch View (512 Bytes) gogo tanaka, 07/18/2014 05:47 AM

Associated revisions

Revision 46861
Added by Hiroshi SHIBATA over 2 years ago

  • test/matrix/test_matrix.rb: Add tests for Matrix class. [Feature #10057]

Revision 46861
Added by Hiroshi SHIBATA over 2 years ago

  • test/matrix/test_matrix.rb: Add tests for Matrix class. [Feature #10057]

Revision 46861
Added by Hiroshi SHIBATA over 2 years ago

  • test/matrix/test_matrix.rb: Add tests for Matrix class. [Feature #10057]

History

#1 [ruby-core:63811] Updated by Hiroshi SHIBATA over 2 years ago

Please split new feature and tests into another issue.

#2 [ruby-core:63813] Updated by gogo tanaka over 2 years ago

@ Hiroshi SHIBATA さん

I split patch "reorder_Matrix#real_and_Matrix_imaginary.patch" to https://bugs.ruby-lang.org/issues/10058

How can I delete patch from feature ?

承知致しました.

7つのPATCHの内、"reorder_Matrix#real_and_Matrix_imaginary.patch"

はこちら https://bugs.ruby-lang.org/issues/10058 に切り出させて頂きました.

一度featureに添付したPATCHは削除出来ないのでしょうか.

#3 [ruby-core:63814] Updated by Hiroshi SHIBATA over 2 years ago

  • File deleted (reorder_Matrix#real_and_Matrix_imaginary.patch)

#4 [ruby-core:63815] Updated by Hiroshi SHIBATA over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Open to Closed

Applied in changeset r46861.


  • test/matrix/test_matrix.rb: Add tests for Matrix class. [Feature #10057]

#5 [ruby-core:63821] Updated by Marc-Andre Lafortune over 2 years ago

Gogo Tanaka san,

Thanks for these additional tests.

Please note that the vast majority of tests of the Matrix library are in RubySpec: https://github.com/rubysl/rubysl-matrix

I hope you'll find them extensive, having for instance many more tests than found in this patch imaginary. If you'd like to port them this would be great.

#6 [ruby-core:63831] Updated by gogo tanaka over 2 years ago

@ Hiroshi SHIBATA さん

ファイルの削除や進捗、ステータスのハンドリングありがとうございます.

Thank you for your some supports.

@ Mr. Marc-Andre Lafortune

I don't know that ... ! it's great! Thank you for your kindness!!!

Also available in: Atom PDF