Project

General

Profile

Actions
Copy link

Bug #10368

closed

GC mark miss on bindings

Bug #10368: GC mark miss on bindings

Added by ktsj (Kazuki Tsujimoto) almost 12 years ago. Updated almost 12 years ago.

Status:
Closed
Assignee:
ko1 (Koichi Sasada)
Target version:
-
ruby -v:
ruby 2.2.0dev (2014-10-11 trunk 47881) [x86_64-linux]
Backport:
2.0.0: DONE, 2.1: DONE
[ruby-dev:48616]

Description

以下のコードでSEGVすることがあります。
mに渡したブロックがGCされてしまうのが原因です。

def m
  binding
end

GC.stress = true
b = nil
tap do 
  b = m {}
end
GC.start
0.times.to_a
b.eval('yield')

ブロックに対応するProcオブジェクトをrb_binding_tに持たせるようにするパッチを添付します。

Files

Download all files
0001-add-blockprocval-to-rb_block_t.patch (4.87 KB) 0001-add-blockprocval-to-rb_block_t.patch ktsj (Kazuki Tsujimoto), 10/11/2014 10:56 AM
0002-use-rb_vm_make_binding-instead-of-rb_binding_new_with_cfp.patch (1.9 KB) 0002-use-rb_vm_make_binding-instead-of-rb_binding_new_with_cfp.patch ktsj (Kazuki Tsujimoto), 10/11/2014 10:56 AM

Updated by ktsj (Kazuki Tsujimoto) almost 12 years ago Actions
Copy link
 #1 [ruby-dev:48659]

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r48000.

  • vm_core.h, vm.c, proc.c: fix GC mark miss on bindings.
    [ruby-dev:48616] [Bug #10368]

  • test/ruby/test_eval.rb: add a test code.

Updated by nagachika (Tomoyuki Chikanaga) almost 12 years ago Actions
Copy link
 #2 [ruby-dev:48661]

  • Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED to 2.0.0: REQUIRED, 2.1: DONE

Backported into ruby_2_1 at r48004.

Updated by usa (Usaku NAKAMURA) almost 12 years ago Actions
Copy link
 #3 [ruby-dev:48677]

  • Backport changed from 2.0.0: REQUIRED, 2.1: DONE to 2.0.0: DONE, 2.1: DONE

Backported into ruby_2_0_0 at r48048.

Actions
Copy link

Also available in: PDF Atom