Project

General

Profile

Actions
Copy link

Feature #10508

closed

Return enumerator in TSort iterators

Added by ptico (Andrey Savchenko) over 9 years ago. Updated over 2 years ago.

Status:
Closed
Assignee:
akr (Akira Tanaka)
Target version:
-
[ruby-core:66270]

Description

Return an Enumerator if no block is given for:

  • TSort.tsort_each
  • TSort.each_strongly_connected_component
  • TSort.each_strongly_connected_component_from

Files

0001-Return-enumerator-in-TSort-each_-methods.patch (3.27 KB) 0001-Return-enumerator-in-TSort-each_-methods.patch ptico (Andrey Savchenko), 11/13/2014 09:04 PM
Actions
Copy link
 #1 [ruby-core:66273]

Updated by marcandre (Marc-Andre Lafortune) over 9 years ago

  • Assignee set to akr (Akira Tanaka)

Looks good.

Actions
Copy link
 #2 [ruby-core:66275]

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

Unnecessary Enumerator slows the performance down.

Actions
Copy link
 #3 [ruby-core:66281]

Updated by ptico (Andrey Savchenko) over 9 years ago

If you mean these .to_a calls, i have created dummy benchmark: https://gist.github.com/Ptico/a16a5fe221de91166c31 and it looks good

Actions
Copy link
 #4 [ruby-core:66482]

Updated by akr (Akira Tanaka) over 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset ruby-trunk:r48584.

  • lib/tsort.rb: Returns an enumerator if no block is given.
    [ruby-core:66270] [Feature #10508] Proposed by Andrey Savchenko.
Actions
Copy link
 #5

Updated by hsbt (Hiroshi SHIBATA) over 2 years ago

  • Project changed from 14 to Ruby master
  • Target version deleted (Ruby 2.2.0)
Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0