Project

General

Profile

Actions

Bug #10693

closed

Regression in Ripper for keyword arg default params

Added by lsegal (Loren Segal) almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:67315]

Description

Easy to reproduce, seems to only be present in 2.2:

$ ruby -v
ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-darwin14]
$ ruby -rripper -e 'p Ripper.sexp "def x(a:1) end"'
[:program, [[:def, [:@ident, "x", [1, 4]], [:paren, [:params, nil, nil, nil, nil, [[17568, [:@int, "1", [1, 8]]]], nil, nil]], [:bodystmt, [[:void_stmt]], nil, nil, nil]]]]

Note the 17568 instead of the expected identifier name. I assume 17568 is the interned symbol index value instead of the value itself. Expecting to see "a" instead of this Fixnum.

Updated by nobu (Nobuyoshi Nakada) almost 7 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r49140.


parse.y: fix f_label result

  • parse.y (f_label): return tLABEL value as it is. [ruby-core:67315] [Bug #10693]

Updated by hsbt (Hiroshi SHIBATA) almost 7 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED

Updated by naruse (Yui NARUSE) almost 7 years ago

  • Backport changed from 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONE

ruby_2_2 r49280 merged revision(s) 49140.

Actions

Also available in: Atom PDF