Bug #10858: File.expand_path on Windows does not handle drive-current path if 2nd arg is relative

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.2.0p43 (2015-02-06 revision 49530) [i386-mswin32_120]
• Backport: 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE

[djberg96 (Daniel Berger)]

On Windows, if the first argument to File.expand_path is a drive-current path, and the dir argument is relative, you get a bogus result:

irb(main):001:0> File.expand_path("c:foo", "bar")
=> "C:/Users/djberge/Repositories/bar/c:foo"

Compare that with Ruby 1.8:

irb(main):002:0> RUBY_VERSION
=> "1.8.7"
irb(main):003:0> File.expand_path('c:foo', "bar")
=> "C:/Users/djberge/Repositories/bar/foo"

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)
• Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: REQUIRED

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

Applied in changeset r49618.

---

win32/file.c: fix drive letter

• win32/file.c (rb_file_expand_path_internal): do not make invalid
  (or ADS) path if the path has a drive letter, the result also
  should have be under it. [ruby-core:68130] [Bug #10858]

[naruse (Yui NARUSE)]

• Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: DONE

ruby_2_2 r49671 merged revision(s) 49618,49640.

[usa (Usaku NAKAMURA)]

• Backport changed from 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: DONE to 2.0.0: REQUIRED, 2.1: DONE, 2.2: DONE

ruby_2_1 r50669 merged revision(s) 49618,49640.