Bug #11037: Time Parse Documentation Incorrect - Undefined method getlocal

• Status: Closed
• Assignee: akr (Akira Tanaka)
• Target version: -
• ruby -v: ruby 2.2.1p85 (2015-02-26 revision 49769) [x64-mingw32]
• Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN

[cfis (Charlie Savage)]

According to:

http://ruby-doc.org/stdlib-2.2.1/libdoc/time/rdoc/Time.html

Time#parse can take a 2nd parameter:

We can change the date used to infer our missing elements by passing a second object that responds to mon, day and year, such as Date, Time or DateTime. We can also use our own object.

However, that is not correct:

irb(main):010:0> Time.parse('12:30 AM', Date.today)
NoMethodError: undefined method `getlocal' for #<Date: 2015-04-07 ((2457120j,0s,0n),+0s,2299161j)>
        from C:/mingw64/mingw64/local/ruby/lib/ruby/2.2.0/time.rb:262:in `make_time'
        from C:/mingw64/mingw64/local/ruby/lib/ruby/2.2.0/time.rb:364:in `parse'
        from (irb):10
        from C:/mingw64/mingw64/local/ruby/bin/irb:11:in `<main>'

The problem is in Time#make_time, lines 259 through 263:

  if off
    now = now.getlocal(off) if now.utc_offset != off
  else
    now = now.getlocal
  end

The behavior the documentation does seem desirable, so the code above should check if the now parameter responds to getlocal or not (only Time does, Date and DateTime do not). Or of course the documentation should be updated to specify that a time object must be passed as the now parameter.

[nkmrya (Yasuhiro Nakamura)]

• File time_parse.patch added

Hi,

I think it is useful Time.parse specifications on the document.
This patch is fix operation to along specifications.

[nobu (Nobuyoshi Nakada)]

    md = MyDate.new(28, 10, 2010)

I don't believe that 2010/28/10 is a valid date.

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)

[nkmrya (Yasuhiro Nakamura)]

• File time_parse.patch added

Sory my careless mistake.
I correct mistake in test case.

[nkmrya (Yasuhiro Nakamura)]

• File deleted (time_parse.patch)

[nkmrya (Yasuhiro Nakamura)]

• File deleted (time_parse.patch)

[nkmrya (Yasuhiro Nakamura)]

• File time_parse.patch time_parse.patch added

The new patch has passed tests.
Could you review the patch again?

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Assigned
• Assignee set to akr (Akira Tanaka)

[citrusmoose (Matt Rice)]

What is the status of this?

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed

Applied in changeset trunk|r64975.

---

Time.parse based from non-Time object

• lib/time.rb (Time.make_time): as the document states, the second
  argument of Time.parse may be a non-Time object which does not
  have getlocal method, assume it is in the local time in the case.
  based on the patch by nkmrya (Yasuhiro Nakamura) at
  [ruby-core:68775]. [ruby-core:68775] [Bug #11037]

Co-authored-by: nkmrya (Yasuhiro Nakamura) [e-mail]