Feature #11124: [PATCH] lib/*: use monotonic clock for timeouts

• Status: Closed
• Assignee: akr (Akira Tanaka)
• Target version: -

[normalperson (Eric Wong)]

The monotonic clock is preferred as it is guaranteed to be
continuous and not subject to jumps due to adjustments.

Given the identical "now" method in both files (and similar code in
lib/benchmark.rb), I wonder if we should implement something like
Process.now instead...

Anyways, I'll commit this patch as-is in a few weeks/months unless there's
objections.

[normalperson (Eric Wong)]

Just checking, which systems do we support do not have CLOCK_MONOTONIC
(emulated or otherwise).

We already emulate it with mach_absolute_time() and times(), so
I'd like to remove the defined? checks from stdlib if possible.

Thanks.

ref: https://bugs.ruby-lang.org/issues/11124

[normalperson (Eric Wong)]

Eric Wong [e-mail] wrote:

Just checking, which systems do we support do not have CLOCK_MONOTONIC
(emulated or otherwise).

We already emulate it with mach_absolute_time() and times(), so
I'd like to remove the defined? checks from stdlib if possible.

Thanks.

ref: https://bugs.ruby-lang.org/issues/11124

Based on naruse's comment in [ruby-core:64393], I'm inclined to go
with the following which will only use CLOCK_MONOTONIC.

http://80x24.org/spew/m/[e-mail]

[naruse (Yui NARUSE)]

I don't know an environment which doesn't have CLOCK_MONOTONIC though it may be.

2015-05-28 6:13 GMT+09:00 Eric Wong [e-mail]:

Eric Wong [e-mail] wrote:

Just checking, which systems do we support do not have CLOCK_MONOTONIC
(emulated or otherwise).

We already emulate it with mach_absolute_time() and times(), so
I'd like to remove the defined? checks from stdlib if possible.

Thanks.

ref: https://bugs.ruby-lang.org/issues/11124

Based on naruse's comment in [ruby-core:64393], I'm inclined to go
with the following which will only use CLOCK_MONOTONIC.

http://80x24.org/spew/m/[e-mail]

--
NARUSE, Yui [e-mail]

[normalperson (Eric Wong)]

"NARUSE, Yui" [e-mail] wrote:

I don't know an environment which doesn't have CLOCK_MONOTONIC though it may be.

Committed as r50664. Lets hope everything is OK...

[ngoto (Naohisa Goto)]

• Related to Bug #11225: r50776 + r50780 + r50781 changes behavior on systems without HAVE_STRUCT_MSGHDR_MSG_CONTROL added

[ngoto (Naohisa Goto)]

• Related to deleted (Bug #11225: r50776 + r50780 + r50781 changes behavior on systems without HAVE_STRUCT_MSGHDR_MSG_CONTROL)

[akr (Akira Tanaka)]

• Status changed from Open to Closed