Project

General

Profile

Actions

Bug #11368

closed

Fix LocalJumpErrors being raised in OpenSSL tests

Added by jeremyevans0 (Jeremy Evans) almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.3.0dev (2015-07-16 openbsd 51261) [x86_64-openbsd]
[ruby-core:70020]

Description

In many cases in the test suite, server_connect is being called
without a block inside an assert_raises block. This leads to
misleading error messages, such as:

[OpenSSL::SSL::SSLError, Errno::ECONNRESET] exception expected, not.
Class:

This changes the error message for those failures to:

[OpenSSL::SSL::SSLError, Errno::ECONNRESET] expected but nothing was
raised.


Files

Actions #1

Updated by hsbt (Hiroshi SHIBATA) over 8 years ago

  • Status changed from Open to Closed

Applied in changeset r51531.


Actions #2

Updated by nagachika (Tomoyuki Chikanaga) over 8 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: UNKNOWN, 2.1: REQUIRED, 2.2: REQUIRED
Actions #3

Updated by nagachika (Tomoyuki Chikanaga) over 8 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: REQUIRED, 2.2: REQUIRED to 2.0.0: UNKNOWN, 2.1: REQUIRED, 2.2: DONE

Backported into ruby_2_2 branch at r51536.

Actions #4

Updated by usa (Usaku NAKAMURA) over 8 years ago

  • Backport changed from 2.0.0: UNKNOWN, 2.1: REQUIRED, 2.2: DONE to 2.0.0: UNKNOWN, 2.1: DONE, 2.2: DONE

ruby_2_1 r51604 merged revision(s) 51531.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0