Bug #11492: TracePoint API report extra return for defined method - Ruby master - Ruby Issue Tracking System

Bug #11492

TracePoint API report extra return for defined method

Added by os97673 (Oleg Sukhodolsky) almost 5 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

ko1 (Koichi Sasada)

Target version:

ruby -v:

ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]

Backport:

2.0.0: DONTNEED, 2.1: DONE, 2.2: DONE

[ruby-core:<unknown>]

Description

class A
  define_method "method1" do
    # puts "#{method_name}(#{arg})"
    return 1
  end
end

a = A.new

TracePoint.new do |tp|
  printf "%8s %13s %s:%-2d\n", tp.event, tp.method_id, tp.path, tp.lineno
end.enable do
  a.method1
end

Related issues

Updated by os97673 (Oleg Sukhodolsky) almost 5 years ago

MRI 2.2.3 introduced problem with TracePoint events.
For the provided test it reports extra return event for method1

  b_call               ruby-17051.rb:14
    line               ruby-17051.rb:15
    call       method1 ruby-17051.rb:2 
  b_call       method1 ruby-17051.rb:2 
    line       method1 ruby-17051.rb:4 
b_return       method1 ruby-17051.rb:4 
  return       method1 ruby-17051.rb:4 
  return       method1 ruby-17051.rb:15
b_return               ruby-17051.rb:16

while 2.2.2 reports

  b_call               ruby-17051.rb:14
    line               ruby-17051.rb:15
    call       method1 ruby-17051.rb:2 
  b_call       method1 ruby-17051.rb:2 
    line       method1 ruby-17051.rb:4 
b_return       method1 ruby-17051.rb:4 
  return       method1 ruby-17051.rb:15
b_return               ruby-17051.rb:16

This breaks calculation of frame stack's size which is used in debase and byebug

Updated by nagachika (Tomoyuki Chikanaga) almost 5 years ago

Status changed from Open to Assigned
Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED

Updated by ko1 (Koichi Sasada) almost 5 years ago

Status changed from Assigned to Closed

Applied in changeset r51713.

vm.c (hook_before_rewind): prevent kicking :return event while finishing vm_exec func because invoke_block_from_c() kick a :return event for bmethods. [Bug #11492]
test/ruby/test_settracefunc.rb: add a test.

Updated by deivid (David Rodríguez) almost 5 years ago

Oleg, could you link to the original report where you found this out? I'd like to know what kind of bug reports to expect and maybe add a regression test in byebug itself.

Updated by os97673 (Oleg Sukhodolsky) almost 5 years ago

David Rodríguez wrote:

Oleg, could you link to the original report where you found this out? I'd like to know what kind of bug reports to expect and maybe add a regression test in byebug itself.

originally the problem was reported here (https://youtrack.jetbrains.com/issue/RUBY-17051) unfortunately user was unable to provide test and I've investigated the problem using log of event reported by debase