Project

General

Profile

Bug #12007

Newly added Unicode data file doesn't get downloaded

Added by duerst (Martin Dürst) almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.4.0dev (2016-01-19 trunk 53589) [x86_64-cygwin]
[ruby-core:72928]

Description

I added a new Unicode data file that should be downloaded to enc/unicode/8.0.0 in revision 53590, but despite repeated 'make up; make install' commands, the file wasn't downloaded.


Related issues

Related to Ruby master - Bug #12433: uncommon.mk:614: recipe for target 'yes-test-almost' failed - missing UnicodeData.txtClosedActions

Associated revisions

Revision 387e838c
Added by duerst (Martin Dürst) over 3 years ago

ChangeLog: Fixing wrong time on previous commit, and adding
previous commit message to svn [ci skip]

The message on the previous commit should have read:
common.mk: Simplifying Unicode data file download logic to make
it more reliable [Bug #12007]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53634 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 53634
Added by duerst (Martin Dürst) over 3 years ago

ChangeLog: Fixing wrong time on previous commit, and adding
previous commit message to svn [ci skip]

The message on the previous commit should have read:
common.mk: Simplifying Unicode data file download logic to make
it more reliable [Bug #12007]

Revision 53634
Added by duerst (Martin Dürst) over 3 years ago

ChangeLog: Fixing wrong time on previous commit, and adding
previous commit message to svn [ci skip]

The message on the previous commit should have read:
common.mk: Simplifying Unicode data file download logic to make
it more reliable [Bug #12007]

Revision 53634
Added by duerst (Martin Dürst) over 3 years ago

ChangeLog: Fixing wrong time on previous commit, and adding
previous commit message to svn [ci skip]

The message on the previous commit should have read:
common.mk: Simplifying Unicode data file download logic to make
it more reliable [Bug #12007]

Revision 53634
Added by duerst (Martin Dürst) over 3 years ago

ChangeLog: Fixing wrong time on previous commit, and adding
previous commit message to svn [ci skip]

The message on the previous commit should have read:
common.mk: Simplifying Unicode data file download logic to make
it more reliable [Bug #12007]

Revision 615d99b7
Added by duerst (Martin Dürst) over 3 years ago

  • common.mk: Simplifying Unicode data file download logic to make it more reliable (including additional fix not in r53633) [Bug #12007]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53643 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 53643
Added by duerst (Martin Dürst) over 3 years ago

  • common.mk: Simplifying Unicode data file download logic to make it more reliable (including additional fix not in r53633) [Bug #12007]

Revision 53643
Added by duerst (Martin Dürst) over 3 years ago

  • common.mk: Simplifying Unicode data file download logic to make it more reliable (including additional fix not in r53633) [Bug #12007]

Revision 53643
Added by duerst (Martin Dürst) over 3 years ago

  • common.mk: Simplifying Unicode data file download logic to make it more reliable (including additional fix not in r53633) [Bug #12007]

Revision 53643
Added by duerst (Martin Dürst) over 3 years ago

  • common.mk: Simplifying Unicode data file download logic to make it more reliable (including additional fix not in r53633) [Bug #12007]

History

Updated by nobu (Nobuyoshi Nakada) almost 4 years ago

  • Status changed from Open to Feedback

Remove .unicode-8.0.0.time file.
Adding/removing data file should be rare, and not worth to add more rules, I think.

#2

Updated by duerst (Martin Dürst) over 3 years ago

  • Status changed from Feedback to Closed

Applied in changeset r53634.


ChangeLog: Fixing wrong time on previous commit, and adding
previous commit message to svn [ci skip]

The message on the previous commit should have read:
common.mk: Simplifying Unicode data file download logic to make
it more reliable [Bug #12007]

Updated by duerst (Martin Dürst) over 3 years ago

  • Assignee changed from nobu (Nobuyoshi Nakada) to duerst (Martin Dürst)

Nobuyoshi Nakada wrote:

Remove .unicode-8.0.0.time file.

I know. If it were only about me, I could just download the file by hand, or copy it from another directory. But I want to make sure that everybody who e.g. does testing gets the necessary files.

Adding/removing data file should be rare, and not worth to add more rules, I think.

I agree that adding/removing data files is rare. But we have 'make' to automate things for us. And I was actually able to simplify some rules :-).

P.S.: Sorry about the confusion with the commit; I accidentally pressed the wrong button at the wrong time. It should actually be "applied in changeset r53633".

Updated by shugo (Shugo Maeda) over 3 years ago

  • Status changed from Closed to Open

It seems that RubyCI was broken by this change.

from http://rubyci.s3.amazonaws.com/tk2-243-31075/ruby-trunk/log/20160123T094902Z.fail.html.gz:

== make # 2016-01-23T18:51:51+09:00 (full)
...(snip 380 lines)...
converter for from_UTF_8
done.  (0.06user 0.00system 0.03elapsed)
make[1]: Leaving directory `/home/chkbuild/build/20160123T094902Z/ruby'
generating transdb.h
transdb.h updated
compiling dln.c
compiling localeinit.c
creating verconf.h
verconf.h updated
compiling loadpath.c
/home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:18:in `initialize': No such file or directory @ rb_sysopen - enc/unicode/data/8.0.0/CompositionExclusions.txt (Errno::ENOENT)
    from /home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:18:in `open'
    from /home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:18:in `call'
    from /home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:18:in `search'
    from /home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:35:in `open'
    from ./template/unicode_norm_gen.tmpl:69:in `<main>'
    from /home/naruse/.rbenv/versions/2.2.3/lib/ruby/2.2.0/erb.rb:863:in `eval'
    from /home/naruse/.rbenv/versions/2.2.3/lib/ruby/2.2.0/erb.rb:863:in `result'
    from ./tool/generic_erb.rb:38:in `<main>'
make: *** [.unicode-tables.time] Error 1
exit 2
failed(make)

Updated by hsbt (Hiroshi SHIBATA) over 3 years ago

I reverted r53634 at r53637.

Updated by duerst (Martin Dürst) over 3 years ago

Hiroshi, Shugo, thanks for catching this!

I tested with all kinds of cases, such as only some files missing, all
files missing, even the directory not yet existing, and all these worked.

But I did not check on a completely fresh checkout. I have now been able
to reproduce the problem on a completely fresh checkout, and will
investigate further.

Regards, Martin.

On 2016/01/23 21:10, SHIBATA Hiroshi wrote:

I reverted r53637.

Please investigate and retry this.

On Sat, Jan 23, 2016 at 8:57 PM, shugo@ruby-lang.org wrote:

Issue #12007 has been updated by Shugo Maeda.

Status changed from Closed to Open

It seems that RubyCI was broken by this change.

from http://rubyci.s3.amazonaws.com/tk2-243-31075/ruby-trunk/log/20160123T094902Z.fail.html.gz:

== make # 2016-01-23T18:51:51+09:00 (full)
...(snip 380 lines)...
converter for from_UTF_8
done.  (0.06user 0.00system 0.03elapsed)
make[1]: Leaving directory `/home/chkbuild/build/20160123T094902Z/ruby'
generating transdb.h
transdb.h updated
compiling dln.c
compiling localeinit.c
creating verconf.h
verconf.h updated
compiling loadpath.c
/home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:18:in `initialize': No such file or directory @ rb_sysopen - enc/unicode/data/8.0.0/CompositionExclusions.txt (Errno::ENOENT)
         from /home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:18:in `open'
         from /home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:18:in `call'
         from /home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:18:in `search'
         from /home/chkbuild/build/20160123T094902Z/ruby/tool/vpath.rb:35:in `open'
         from ./template/unicode_norm_gen.tmpl:69:in `<main>'
         from /home/naruse/.rbenv/versions/2.2.3/lib/ruby/2.2.0/erb.rb:863:in `eval'
         from /home/naruse/.rbenv/versions/2.2.3/lib/ruby/2.2.0/erb.rb:863:in `result'
         from ./tool/generic_erb.rb:38:in `<main>'
make: *** [.unicode-tables.time] Error 1
exit 2
failed(make)

Bug #12007: Newly added Unicode data file doesn't get downloaded
https://bugs.ruby-lang.org/issues/12007#change-56543

  • Author: Martin Dürst
  • Status: Open
  • Priority: Normal
  • Assignee: Martin Dürst
  • ruby -v: ruby 2.4.0dev (2016-01-19 trunk 53589) [x86_64-cygwin]

* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN

I added a new Unicode data file that should be downloaded to enc/unicode/8.0.0 in revision 53590, but despite repeated 'make up; make install' commands, the file wasn't downloaded.

--
https://bugs.ruby-lang.org/

#7

Updated by duerst (Martin Dürst) over 3 years ago

  • Status changed from Open to Closed

Applied in changeset r53643.


  • common.mk: Simplifying Unicode data file download logic to make it more reliable (including additional fix not in r53633) [Bug #12007]
#8

Updated by duerst (Martin Dürst) over 3 years ago

  • Related to Bug #12433: uncommon.mk:614: recipe for target 'yes-test-almost' failed - missing UnicodeData.txt added

Also available in: Atom PDF