Feature #12077: Consolidate SSLSocket interface with TCPSocket

• Status: Open
• Assignee: -
• Target version: -

[tonci (Tonči Damjanić)]

Hello,

Is there a reason why SSLSocket#read doesn't work the same as SSLSocket#sysread and why there is no SSLSocket#recv?

Right now it is impossible to have code agnostic in regards to the socket type.

One solution is to monkey-patch OpenSSL::SSL::SSLSocket (see lower) to share the same interface as TCPSocket, but given the generic names of monkey-patched functions, I'm not sure if they could result with some leaks or strange behavior.

class OpenSSL::SSL::SSLSocket
  def read(*args)
    sysread(*args)
  end
  
  def write(*args)
    syswrite(*args)
  end
  
  def close
    sysclose
  end
end

Thoughts?

[tonci (Tonči Damjanić)]

• Description updated (diff)

[tonci (Tonči Damjanić)]

• Description updated (diff)

[tonci (Tonči Damjanić)]

• Assignee set to core

[normalperson (Eric Wong)]

[e-mail] wrote:

Is there a reason why SSLSocket#read doesn't work the same
as SSLSocket#sysread

Because IO#read and IO#sysread are different, too. The former
is read-in-full behavior (outside of EOF) while sysread matches
the low-level C interface and allows for partial reads.

Likewise with write vs syswrite regarding write-in-full
behavior.

and why there is no SSLSocket#recv?

Currently, OpenSSL does not provide an interface to recv(2)
which handles flag arguments :<

I too wish for recv(2) and send(2) interfaces which lets me
use MSG_MORE|MSG_DONTWAIT flags.

[naruse (Yui NARUSE)]

• Assignee deleted (core)

[naruse (Yui NARUSE)]

• Is duplicate of Feature #8126: OpenSSL::SSL::SSLSocket does not define #recv and #send messages added