Project

General

Profile

Bug #12201

nkf.c static void fold_conv part of exression always true

Added by fanantoxa (Anton Sivakov) over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:74472]

Description

/* new line */
    if (fold_preserve_f) {
        f_prev = c1;
        f_line = 0;
        fold_state =  CR;
    } else if ((f_prev == c1 && !fold_preserve_f)
           || (f_prev == LF && fold_preserve_f)
          ) {        /* duplicate newline */

f_prev == c1 && !fold_preserve_f - here expression !fold_preserve_f always true because above we have if (fold_preserve_f) and here 'else if'

(f_prev == LF && fold_preserve_f) - this expression alway will be false for the same reason


Related issues

Related to Ruby master - Bug #12202: nkf.c static void mime_putc the variable being used for loop used for outer loop tooClosedActions

Associated revisions

Revision 1d7cfff0
Added by naruse (Yui NARUSE) over 3 years ago

  • ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0. patched by Anton Sivakov [Bug #12201] [Bug #12202]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54423 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 54423
Added by naruse (Yui NARUSE) over 3 years ago

  • ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0. patched by Anton Sivakov [Bug #12201] [Bug #12202]

Revision 54423
Added by naruse (Yui NARUSE) over 3 years ago

  • ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0. patched by Anton Sivakov [Bug #12201] [Bug #12202]

Revision 54423
Added by naruse (Yui NARUSE) over 3 years ago

  • ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0. patched by Anton Sivakov [Bug #12201] [Bug #12202]

Revision 54423
Added by naruse (Yui NARUSE) over 3 years ago

  • ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0. patched by Anton Sivakov [Bug #12201] [Bug #12202]

Revision 42569dd4
Added by usa (Usaku NAKAMURA) over 3 years ago

merge revision(s) 54423,54489: [Backport #12201] [Backport #12202]

    * ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0.
      patched by Anton Sivakov [Bug #12201] [Bug #12202]

    * ext/nkf/nkf-utf8/nkf.c (mime_putc): fix typo.
      [Bug #12202] [ruby-core:74802]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@54695 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 54695
Added by usa (Usaku NAKAMURA) over 3 years ago

merge revision(s) 54423,54489: [Backport #12201] [Backport #12202]

* ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0.
  patched by Anton Sivakov [Bug #12201] [Bug #12202]

* ext/nkf/nkf-utf8/nkf.c (mime_putc): fix typo.
  [Bug #12202] [ruby-core:74802]

Revision 9224427b
Added by nagachika (Tomoyuki Chikanaga) over 3 years ago

merge revision(s) 54423,54489: [Backport #12201] [Backport #12202]

    * ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0.
      patched by Anton Sivakov [Bug #12201] [Bug #12202]

    * ext/nkf/nkf-utf8/nkf.c (mime_putc): fix typo.
      [Bug #12202] [ruby-core:74802]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@54714 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 54714
Added by nagachika (Tomoyuki Chikanaga) over 3 years ago

merge revision(s) 54423,54489: [Backport #12201] [Backport #12202]

* ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0.
  patched by Anton Sivakov [Bug #12201] [Bug #12202]

* ext/nkf/nkf-utf8/nkf.c (mime_putc): fix typo.
  [Bug #12202] [ruby-core:74802]

History

Updated by fanantoxa (Anton Sivakov) over 3 years ago

  • Assignee set to shyouhei (Shyouhei Urabe)
#2

Updated by naruse (Yui NARUSE) over 3 years ago

  • Status changed from Open to Closed

Applied in changeset r54423.


  • ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0. patched by Anton Sivakov [Bug #12201] [Bug #12202]

Updated by usa (Usaku NAKAMURA) over 3 years ago

  • Backport changed from 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN to 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED
#4

Updated by usa (Usaku NAKAMURA) over 3 years ago

  • Related to Bug #12202: nkf.c static void mime_putc the variable being used for loop used for outer loop too added

Updated by usa (Usaku NAKAMURA) over 3 years ago

  • Backport changed from 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED to 2.1: WONTFIX, 2.2: DONE, 2.3: REQUIRED

ruby_2_2 r54695 merged revision(s) 54423,54489.

Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago

  • Backport changed from 2.1: WONTFIX, 2.2: DONE, 2.3: REQUIRED to 2.1: WONTFIX, 2.2: DONE, 2.3: DONE

ruby_2_3 r54714 merged revision(s) 54423,54489.

Also available in: Atom PDF