Bug #12201: nkf.c static void fold_conv part of exression always true

• Status: Closed
• Assignee: shyouhei (Shyouhei Urabe)
• Target version: -
• Backport: 2.1: WONTFIX, 2.2: DONE, 2.3: DONE

[fanantoxa (Anton Sivakov)]

/* new line */
	if (fold_preserve_f) {
	    f_prev = c1;
	    f_line = 0;
	    fold_state =  CR;
	} else if ((f_prev == c1 && !fold_preserve_f)
		   || (f_prev == LF && fold_preserve_f)
		  ) {        /* duplicate newline */

f_prev == c1 && !fold_preserve_f - here expression !fold_preserve_f always true because above we have if (fold_preserve_f) and here 'else if'

(f_prev == LF && fold_preserve_f) - this expression alway will be false for the same reason

[fanantoxa (Anton Sivakov)]

• Assignee set to shyouhei (Shyouhei Urabe)

[naruse (Yui NARUSE)]

• Status changed from Open to Closed

Applied in changeset r54423.

---

• ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0.
  patched by Anton Sivakov [Bug #12201] [Bug #12202]

[usa (Usaku NAKAMURA)]

• Backport changed from 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN to 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED

[usa (Usaku NAKAMURA)]

• Related to Bug #12202: nkf.c static void mime_putc the variable being used for loop used for outer loop too added

[usa (Usaku NAKAMURA)]

• Backport changed from 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED to 2.1: WONTFIX, 2.2: DONE, 2.3: REQUIRED

ruby_2_2 r54695 merged revision(s) 54423,54489.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.1: WONTFIX, 2.2: DONE, 2.3: REQUIRED to 2.1: WONTFIX, 2.2: DONE, 2.3: DONE

ruby_2_3 r54714 merged revision(s) 54423,54489.