Project

General

Profile

Actions

Bug #12201

closed

nkf.c static void fold_conv part of exression always true

Added by fanantoxa (Anton Sivakov) over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:74472]

Description

/* new line */
	if (fold_preserve_f) {
	    f_prev = c1;
	    f_line = 0;
	    fold_state =  CR;
	} else if ((f_prev == c1 && !fold_preserve_f)
		   || (f_prev == LF && fold_preserve_f)
		  ) {        /* duplicate newline */

f_prev == c1 && !fold_preserve_f - here expression !fold_preserve_f always true because above we have if (fold_preserve_f) and here 'else if'

(f_prev == LF && fold_preserve_f) - this expression alway will be false for the same reason


Related issues 1 (0 open1 closed)

Related to Ruby master - Bug #12202: nkf.c static void mime_putc the variable being used for loop used for outer loop tooClosedActions

Updated by fanantoxa (Anton Sivakov) over 6 years ago

  • Assignee set to shyouhei (Shyouhei Urabe)
Actions #2

Updated by naruse (Yui NARUSE) over 6 years ago

  • Status changed from Open to Closed

Applied in changeset r54423.


  • ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0.
    patched by Anton Sivakov [Bug #12201] [Bug #12202]

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • Backport changed from 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN to 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED
Actions #4

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • Related to Bug #12202: nkf.c static void mime_putc the variable being used for loop used for outer loop too added

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • Backport changed from 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED to 2.1: WONTFIX, 2.2: DONE, 2.3: REQUIRED

ruby_2_2 r54695 merged revision(s) 54423,54489.

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Backport changed from 2.1: WONTFIX, 2.2: DONE, 2.3: REQUIRED to 2.1: WONTFIX, 2.2: DONE, 2.3: DONE

ruby_2_3 r54714 merged revision(s) 54423,54489.

Actions

Also available in: Atom PDF