Feature #12224: logger: Allow specifying log level in constructor

• Status: Closed
• Assignee: sonots (Naotoshi Seo)
• Target version: -

[rhenium (Kazuki Yamaguchi)]

When I use Logger class, I very often (or maybe always) set minimal log level together. Since method chaining can't be used for setters, we have to split it into two statements:

logger = Logger.new($stdout)
logger.level = :info

Imagine if the logger was much longer name, such as ActiveRecord::Base.logger. I personally don't want to repeat it.
I found a number of samples on GitHub (they would countain copy-and-pastes though) [1].

So I propose adding a new keyword argument level to Logger.new:

logger = Logger.new($stdout, level: :info)

This will be effectively same as the original code I indicated above.

I attached a patch for this.

[1] https://github.com/search?utf8=%E2%9C%93&q=%22%3D+Logger.new%22+%22level+%3D%22+language%3ARuby&type=Code&ref=searchresults

[shevegen (Robert A. Heiler)]

Here is the link to Logger:

http://ruby-doc.org/stdlib-2.3.0/libdoc/logger/rdoc/Logger.html#method-c-new

It already uses multiple arguments:

new(logdev, shift_age = 7, shift_size = 1048576)
new(logdev, shift_age = 'weekly') 

So I assume another optional one such as :level would be ok (my personal opinion).

[sonots (Naotoshi Seo)]

• Assignee set to sonots (Naotoshi Seo)

[sonots (Naotoshi Seo)]

• Status changed from Open to Closed

Applied in changeset r54638.

---

Allow specifying logger parameters in constructor

• lib/logger.rb: Allow specifying logger prameters such as level,
  progname, datetime_format, formatter in constructor [Bug #12224]

[nobu (Nobuyoshi Nakada)]

• Has duplicate Feature #13244: stdlib/Logger: add option: level added