Project

General

Profile

Actions

Bug #12255

closed

[DOC] Small fix for rdoc of ext/json/lib/json/add/*

Added by stomar (Marcus Stollsteimer) about 8 years ago. Updated over 7 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 2.3.0p0 (2015-12-25 revision 53290) [i686-linux]
[ruby-core:74835]

Description

This patch removes some comments that otherwise would appear in the docs of the affected classes.

E.g. for Exception

$ ri Exception
Descendants of class Exception are used to [...]

[snipped class documentation]

Exception serialization/deserialization        <- does not belong here!
-------------------------------------------
Class methods:

[snip]


Files

doc-json-add.patch (3.17 KB) doc-json-add.patch stomar (Marcus Stollsteimer), 04/06/2016 07:19 PM

Updated by hsbt (Hiroshi SHIBATA) almost 8 years ago

I agreed your fixes and patch.
But json in ruby core is not upstream repository.

Can you submit patch to http://github.com/flori/json ?

Updated by hsbt (Hiroshi SHIBATA) almost 8 years ago

  • Status changed from Open to Assigned
  • Assignee set to hsbt (Hiroshi SHIBATA)

Updated by stomar (Marcus Stollsteimer) almost 8 years ago

The pull request has now been merged upstream.

Actions #6

Updated by hsbt (Hiroshi SHIBATA) almost 8 years ago

  • Status changed from Assigned to Closed

Applied in changeset r55380.


  • ext/json/lib/*.rb: Removed some comments. Because these are unnecessary
    class description. [ci skip][Bug #12255][ruby-core:74835]

Updated by usa (Usaku NAKAMURA) over 7 years ago

  • Backport changed from 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN to 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED

Updated by nagachika (Tomoyuki Chikanaga) over 7 years ago

  • Backport changed from 2.1: WONTFIX, 2.2: REQUIRED, 2.3: REQUIRED to 2.1: WONTFIX, 2.2: REQUIRED, 2.3: DONE

ruby_2_3 r55855 merged revision(s) 55380.

Updated by usa (Usaku NAKAMURA) over 7 years ago

  • Backport changed from 2.1: WONTFIX, 2.2: REQUIRED, 2.3: DONE to 2.1: WONTFIX, 2.2: DONE, 2.3: DONE

ruby_2_2 r55928 merged revision(s) 55380.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0