Bug #12485: Kernel.Rational raises TypeError though given denominator returns 1 by to_int

• Status: Closed
• Assignee: mrkn (Kenta Murata)
• Target version: -
• ruby -v: ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]
• Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
• Tags: core, patch, maybenotbug

[mrkn (Kenta Murata)]

Is it an intentional behavior?

class << (o = Object.new)
  def to_int
    1
  end
end

Rational(1, o)  #=> TypeError: not an integer

[mrkn (Kenta Murata)]

• File rational.c.diff rational.c.diff added

Attached patch can fix this issue.

[nobu (Nobuyoshi Nakada)]

You can use RB_INTEGER_TYPE_P in the trunk.

[mrkn (Kenta Murata)]

Nobuyoshi Nakada wrote:

You can use RB_INTEGER_TYPE_P in the trunk.

I forgot it. Thanks.

[jeremyevans0 (Jeremy Evans)]

• File rational-denom-to_int.patch rational-denom-to_int.patch added

I'm not sure if this is considered a bug or not. Rational will already try to convert numerator and denominator via to_r. However, if we do want to convert via to_int if to_r is not defined, the attached patch should implement it.

[mrkn (Kenta Murata)]

• Status changed from Open to Assigned
• Assignee set to mrkn (Kenta Murata)

I'm working on this at https://github.com/ruby/ruby/pull/3684

• Status changed from Assigned to Closed

Applied in changeset git|d23d5c3130a0944e7e591370cbf8599009318a7c.

---

rational.c: try converting by to_int in Rational() (#3684)

[Bug #12485]