Feature #12534

Refinements: refine modules as well

Added by chucke (Tiago Cardoso) about 4 years ago. Updated almost 4 years ago.

Target version:


Refinements were added as a feature to scope monkey-patches on ruby core elements. This works for elements such as String, Array (all classes), but not for modules (Enumerable, Timeout...).

This might be related to refinements not working for singleton classes (for example, I can't define a class method inside a refine block).

This code is evaluated, but the method is undefined:

module Extension
refine Array do
def ; puts "bar" ; end

This code breaks:

module Extension
refine Kernel do
def foo ; puts "bar" ; end

Updated by shevegen (Robert A. Heiler) about 4 years ago

Interesting. I was not aware of this.

It is however mentioned in the documentation:


"Refinements only modify classes, not modules so the argument must be a class."

As to why, I don't know either. Perhaps the documentation can add some words
to briefly state whether this is on purpose or not.

Updated by shugo (Shugo Maeda) about 4 years ago

  • Assignee set to shugo (Shugo Maeda)
  • Status changed from Open to Feedback

There is an implementation difficulty when refining modules and calling super in that refinement.

One solution is prohibiting super in a refinement for a module.
Other proposals (and patches) are welcome.

Updated by matz (Yukihiro Matsumoto) almost 4 years ago

I understand the implementation difficulty. If we prohibit super in refined methods in Modules, is it possible to refine modules?
If it's reasonably possible, I'd like to accept this.



Updated by shugo (Shugo Maeda) almost 4 years ago

  • Status changed from Feedback to Closed

Applied in changeset r56213.

  • eval.c (rb_mod_refine): refine modules as well. [ruby-core:76199] [Feature #12534]

Also available in: Atom PDF