Refinements: refine modules as well
Refinements were added as a feature to scope monkey-patches on ruby core elements. This works for elements such as String, Array (all classes), but not for modules (Enumerable, Timeout...).
This might be related to refinements not working for singleton classes (for example, I can't define a class method inside a refine block).
This code is evaluated, but the method is undefined:
refine Array do
def self.foo ; puts "bar" ; end
This code breaks:
refine Kernel do
def foo ; puts "bar" ; end
- eval.c (rb_mod_refine): refine modules as well. [ruby-core:76199] [Feature #12534]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56213 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
vm_method.c: update assertion [ci skip]
- vm_method.c (prepare_callable_method_entry): update assertion as defined_class may be T_MODULE not only I_ICLASS since r56213. [Feature #12534]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
vm_insnhelper.c: update assertion [ci skip]
- vm_insnhelper.c (callable_class_p): update assertion as callable class may be T_MODULE or I_ICLASS which refines a module since r56213. [Feature #12534]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Updated by shevegen (Robert A. Heiler) over 3 years ago
Interesting. I was not aware of this.
It is however mentioned in the documentation:
"Refinements only modify classes, not modules so the argument must be a class."
As to why, I don't know either. Perhaps the documentation can add some words
to briefly state whether this is on purpose or not.
Updated by shugo (Shugo Maeda) over 3 years ago
- Assignee set to shugo (Shugo Maeda)
- Status changed from Open to Feedback
There is an implementation difficulty when refining modules and calling
super in that refinement.
One solution is prohibiting
super in a refinement for a module.
Other proposals (and patches) are welcome.