Forwardable breaks on private methods in ruby 2.4
Due to an optimization in r55376, attempting to forward to private methods no longer works in ruby 2.4. Among other things, this breaks haml template support in tilt. Example:
require 'forwardable' class Foo private def foo; :foo end extend Forwardable def_delegator :itself, :foo, :bar end p Foo.new.bar
On ruby 2.3, this outputs :foo, on 2.4.0preview2 it raises NoMethodError. I think r55376 should be reverted, as the optimization it uses does not appear to be able to handle private method calls.
forwardable.rb: private methods
- lib/forwardable.rb (_delegator_method): allow private methods to be delegated, with warnings. [ruby-core:77341] [Bug #12782]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Updated by jeremyevans0 (Jeremy Evans) almost 3 years ago
- Assignee set to matz (Yukihiro Matsumoto)
Nobuyoshi Nakada wrote:
I suspect that it was a bug to able to delegate a private method.
It does seem like a bad idea to allow forwarding to private methods. However, the commit message did not mention that it fixes a bug, so I believe the behavior change was unintentional. Allowing delegating to private methods dates to forwardable's initial commit (in ruby 1.6), and there are ruby libraries relying on this behavior (tilt's haml support at least). Assigning to matz to make a decision on whether to break backwards compatibility.