Bug #13081: resolv.rb may be the cause of the rubygems bug on Windows

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.3.3p222 (2016-11-21 revision 56859) [x64-mingw32]
• Backport: 2.2: DONE, 2.3: DONE, 2.4: DONE

[kozo2 (Kozo Nishida)]

See https://github.com/rubygems/rubygems/issues/1700

[nobu (Nobuyoshi Nakada)]

Seems the registry is broken.

[nobu (Nobuyoshi Nakada)]

s/repository/registry/

[kou (Kouhei Sutou)]

How about ignoring the registry value if its type is not expected type?

Index: resolv.rb
===================================================================
--- resolv.rb	(revision 57233)
+++ resolv.rb	(working copy)
@@ -75,8 +75,10 @@
         nameserver = get_dns_server_list
         Registry::HKEY_LOCAL_MACHINE.open(TCPIP_NT) do |reg|
           begin
-            slist = reg.read_s('SearchList')
-            search = slist.split(/,\s*/) unless slist.empty?
+            type, slist = reg.read('SearchList')
+            if type == Registory::REG_SZ
+              search = slist.split(/,\s*/) unless slist.empty?
+            end
           rescue Registry::Error
           end

[nobu (Nobuyoshi Nakada)]

Yes, Windows seems to ignore the value when it is not REG_SZ, too.
But I wonder if it is desirable to ignore such broken registry silently.

[usa (Usaku NAKAMURA)]

I think that to warn and ignore is nice.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset r57265.

---

win32/resolv.rb: ad hoc workaround

• ext/win32/lib/win32/resolv.rb (Win32::Resolv::SZ): an ad hoc
  workaround for broken registry. SearchList and other registry
  values must be REG_SZ, or Windows ignores anything in those
  values otherwise. [ruby-dev:49924] [Bug #13081]
  https://github.com/rubygems/rubygems/issues/1700

[nobu (Nobuyoshi Nakada)]

All registry read operations should warn and return an empty string, instead of TypeError?

[usa (Usaku NAKAMURA)]

Of course, only for this case.
We can not assume the use case of a registry value generally, as you know.

[kozo2 (Kozo Nishida)]

Nobuyoshi Nakada wrote:

Applied in changeset r57265.

---

win32/resolv.rb: ad hoc workaround

• ext/win32/lib/win32/resolv.rb (Win32::Resolv::SZ): an ad hoc
  workaround for broken registry. SearchList and other registry
  values must be REG_SZ, or Windows ignores anything in those
  values otherwise. [ruby-dev:49924] [Bug #13081]
  https://github.com/rubygems/rubygems/issues/1700

How can I reflect this update to our local Ruby+Windows environment?

(of course this fails.)

C:\Ruby23\bin>gem update --system
ERROR:  While executing gem ... (TypeError)
    Type mismatch (expect [1] but 3 present)

[usa (Usaku NAKAMURA)]

• Backport changed from 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN to 2.2: REQUIRED, 2.3: REQUIRED, 2.4: REQUIRED

[usa (Usaku NAKAMURA)]

• Backport changed from 2.2: REQUIRED, 2.3: REQUIRED, 2.4: REQUIRED to 2.2: DONE, 2.3: REQUIRED, 2.4: REQUIRED

ruby_2_2 r58119 merged revision(s) 57265,57266.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.2: DONE, 2.3: REQUIRED, 2.4: REQUIRED to 2.2: DONE, 2.3: DONE, 2.4: REQUIRED

ruby_2_3 r58172 merged revision(s) 57265,57266.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.2: DONE, 2.3: DONE, 2.4: REQUIRED to 2.2: DONE, 2.3: DONE, 2.4: DONE

ruby_2_4 r58630 merged revision(s) 57265,57266.