Project

General

Profile

Bug #1309

dl tests

Added by cfis (Charlie Savage) almost 11 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Normal
Target version:
ruby -v:
ruby 1.9.2dev (2009-03-21) [i386-mswin32_90]
Backport:
[ruby-core:22990]

Description

=begin
The dl tests now pass again on windows (thanks!).

However, instead of getting the runtime library name from the dll name, it seems more appropriate to use the site-arch config setting.

Patch attached.
=end


Files

test_base.patch (536 Bytes) test_base.patch cfis (Charlie Savage), 03/22/2009 04:58 PM

History

#1

Updated by nobu (Nobuyoshi Nakada) almost 11 years ago

=begin
Hi,

At Sun, 22 Mar 2009 16:55:56 +0900,
Charlie Savage wrote in [ruby-core:22990]:

However, instead of getting the runtime library name from the
dll name, it seems more appropriate to use the site-arch
config setting.

What's the reason?

--
Nobu Nakada

=end

#2

Updated by cfis (Charlie Savage) almost 11 years ago

=begin
Two reasons.

First is philosophical. Using "sitearch" seems more apppriate than "RUBY_SO_NAME" - that is the point of sitearch isn't it?

Second is practical. I continue to hope that I'll be able to convince ruby core that the shared library name on windows should be ruby19.dll (I'll be sending another email soon :). Therefore RUBY_SO_NAME will no longer work for this.

Charlie

=end

#3

Updated by nobu (Nobuyoshi Nakada) almost 11 years ago

=begin
Hi,

At Mon, 23 Mar 2009 07:54:54 +0900,
Charlie Savage wrote in [ruby-core:22997]:

First is philosophical. Using "sitearch" seems more apppriate
than "RUBY_SO_NAME" - that is the point of sitearch isn't it?

RUBY_SO_NAME is too.

Second is practical. I continue to hope that I'll be able to
convince ruby core that the shared library name on windows
should be ruby19.dll (I'll be sending another email soon :).
Therefore RUBY_SO_NAME will no longer work for this.

I had explained why it can't. Do you have any suggestion for
workaround?

--
Nobu Nakada

=end

#4

Updated by cfis (Charlie Savage) almost 11 years ago

=begin
Hi Nobu,

Let's take the dll naming issue back to ruby-core, I'll post there in the next couple of days.

I'd still like this test to use sitearch. Is there any good reason why it can't?

Charlie
=end

#5

Updated by yugui (Yuki Sonoda) over 10 years ago

  • Assignee set to nobu (Nobuyoshi Nakada)
  • Target version changed from 1.9.1 to 1.9.2

=begin

=end

#6

Updated by usa (Usaku NAKAMURA) almost 10 years ago

  • Status changed from Open to Rejected

=begin

=end

Also available in: Atom PDF