Feature #13665: String#delete_suffix

• Status: Closed
• Assignee: -
• Target version: -

[sonots (Naotoshi Seo)]

In https://bugs.ruby-lang.org/issues/12694, we decided to have String#delete_prefix.
It would be nice to have String#delete_suffix method to delete suffix from a string for symmetry although it can be achieved with String#chomp as:

class String
  def delete_suffix(substr)
    chomp(substr)
  end
  def delete_suffix!(substr)
    chomp!(substr)
  end
end

Any opinions?

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)

At yesterday meeting, a name lchomp was proposed but rejected because of the special deal of CR LF.
If delete_suffix will be introduced, it should keep CR before LF when the argument is LF only, as well as delete_prefix.

[shevegen (Robert A. Heiler)]

I think the method's functionality is good to have.

[sonots (Naotoshi Seo)]

I've sent a PR https://github.com/ruby/ruby/pull/1661.
I will merge if I get agreement at a ruby developer's meeting.

[matz (Yukihiro Matsumoto)]

Looks good to me.

Matz.

[sonots (Naotoshi Seo)]

• Status changed from Open to Closed

Applied in changeset trunk|r59377.

---

string.c: add String#delete_suffix and String#delete_suffix!
to remove trailing suffix [Feature #13665] [Fix GH-1661]

• string.c (rb_str_delete_suffix_bang): add a new method
  to remove suffix destuctively.

• string.c (rb_str_delete_suffix): add a new method
  to remove suffix non-destuctively.

• test/ruby/test_string.rb: add tests.