Bug #13816: APFS Issue with High Sierra

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.5.0dev (2017-08-15 trunk 59592) [x86_64-darwin17]
• Backport: 2.2: DONTNEED, 2.3: DONE, 2.4: DONE

[hsbt (Hiroshi SHIBATA)]

I found fail results of make test-all with High Sierra Beta 6 and APFS.

~/D/r/trunk > mk test-all
Run options: "--ruby=./miniruby -I../../github.com/ruby/ruby/lib -I. -I.ext/common  ../../github.com/ruby/ruby/tool/runruby.rb --extout=.ext  -- --disable-gems" --excludes-dir=../../github.com/ruby/ruby/test/excludes --name=!/memory_leak/

# Running tests:

[ 4553/17206] TestDir_M17N#test_filename_extutf8_invalid = 0.06 s                                                                                               
  1) Error:
TestDir_M17N#test_filename_extutf8_invalid:
Errno::EILSEQ: Illegal byte sequence @ rb_sysopen - ?
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:65:in `initialize'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:65:in `open'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:65:in `<main>'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:63:in `block in test_filename_extutf8_invalid'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:9:in `block (2 levels) in with_tmpdir'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:8:in `chdir'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:8:in `block in with_tmpdir'
    /path/to/github.com/ruby/ruby/lib/tmpdir.rb:89:in `mktmpdir'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:7:in `with_tmpdir'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:62:in `test_filename_extutf8_invalid'

[ 4558/17206] TestDir_M17N#test_glob_encoding = 0.00 s                      
  2) Error:
TestDir_M17N#test_glob_encoding:
Errno::EILSEQ: Illegal byte sequence @ dir_s_mkdir - 目񟕑
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:379:in `mkdir'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:379:in `block in test_glob_encoding'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:9:in `block (2 levels) in with_tmpdir'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:8:in `chdir'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:8:in `block in with_tmpdir'
    /path/to/github.com/ruby/ruby/lib/tmpdir.rb:89:in `mktmpdir'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:7:in `with_tmpdir'
    /path/to/github.com/ruby/ruby/test/ruby/test_dir_m17n.rb:372:in `test_glob_encoding'

[ 5116/17206] TestFileExhaustive#test_atime = 0.05 s                                                 
  3) Failure:
TestFileExhaustive#test_atime [/path/to/github.com/ruby/ruby/test/ruby/test_file_exhaustive.rb:575]:
<2017-08-15 10:21:18 +0900> (795278193[ns]) expected but was
<2017-08-15 10:21:18 +0900> (801104909[ns]).

[ 5130/17206] TestFileExhaustive#test_expand_path = 0.04 s          
  4) Failure:
TestFileExhaustive#test_expand_path [/path/to/github.com/ruby/ruby/test/ruby/test_file_exhaustive.rb:752]:
"file.test".
<"/var/folders/jl/zgy9fk353nd6zn0xznlsdzvc6gxzs5/T/rubytest-file20170815-21818-13n19rm/file.test"> expected but was
<"/var/folders/jl/zgy9fk353nd6zn0xznlsdzvc6gxzs5/T/rubytest-file20170815-21818-13n19rm/file.test">.

[naruse (Yui NARUSE)]

• Status changed from Open to Closed

Applied in changeset trunk|r59602.

---

High Sierra's APFS cannot use invalid filenames [Bug #13816]

[hsbt (Hiroshi SHIBATA)]

• Status changed from Closed to Open

I confirmed to fix TestDir_M17N#test_filename_extutf8_invalid and TestDir_M17N#test_glob_encoding by r59602.

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Closed

Applied in changeset trunk|r59887.

---

added workaround for APFS file format.

• TestFileExhaustive#test_atime: It fails with nano-sec precise.
  I changed to use unixtime for this assertion for APFS.
• TestFileExhaustive#test_expand_path: skip assertion when given
  invalid charactor on APFS.

[Bug #13816][ruby-core:82383]

[hsbt (Hiroshi SHIBATA)]

• Backport changed from 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN to 2.2: DONTNEED, 2.3: REQUIRED, 2.4: REQUIRED

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.2: DONTNEED, 2.3: REQUIRED, 2.4: REQUIRED to 2.2: DONTNEED, 2.3: REQUIRED, 2.4: DONE

ruby_2_4 r62647 merged revision(s) 59602,59887.

[usa (Usaku NAKAMURA)]

• Backport changed from 2.2: DONTNEED, 2.3: REQUIRED, 2.4: DONE to 2.2: DONTNEED, 2.3: DONE, 2.4: DONE

ruby_2_3 r62814 merged revision(s) 59602,59887.