Feature #13983: Rational and Complex should be frozen

• Status: Closed
• Priority: Normal
• Assignee: -
• Target version: 2.5

[Eregon (Benoit Daloze)]

Since they basically are value types.
They also do not support #dup currently:

> 1r.dup
TypeError: can't copy Rational
from `initialize_copy'

> 1i.dup
TypeError: can't copy Complex
from `initialize_copy'

Changing their value can only be considered a semantic bug.

So, let's follow true/false/nil/Integer/Float and friends?

Not sure what #6538 was about but I think Marshal can just freeze after setting the values.
It's slightly incompatible if people do rational.instance_variable_set(:@foo, 1) or so,
but no more than on other now-frozen Numeric types and this kind of code seems highly undesirable.

[Eregon (Benoit Daloze)]

• Related to Feature #13985: Avoid exception for #dup/#clone on Rational and Complex added

[ko1 (Koichi Sasada)]

+1

[matz (Yukihiro Matsumoto)]

Agreed.

Matz.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset trunk|r60214.

---

freeze Complex and Rational

• complex.c (nucomp_s_new_internal, nucomp_loader): Complex
  instances are always frozen now. [Feature #13983]

• rational.c (nurat_s_new_internal, nurat_loader): Rational
  instances are always frozen now. [Feature #13983]

[Eregon (Benoit Daloze)]

• Target version set to 2.5

nobu (Nobuyoshi Nakada) wrote:

Applied in changeset trunk|r60214.

Thank you nobu for the patch!

I'll write some specs for it :)

[Eregon (Benoit Daloze)]

Specs added in r60505