Project

General

Profile

Feature #14230

Binding#source_location

Added by mame (Yusuke Endoh) 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:84435]

Description

How about providing Binding#source_location?

b = binding
p binding.source_location #=> ["test.rb", 1]

To fetch the information, people uses a dirty idiom: eval("[__FILE__, __LINE__]", binding).

I noticed this issue when changing the semantics of eval so that it does not inherit __FILE__ from the binding. [#4352]

diff --git a/lib/irb/workspace.rb b/lib/irb/workspace.rb
index 9ce84b60fa..5216520f32 100644
--- a/lib/irb/workspace.rb
+++ b/lib/irb/workspace.rb
@@ -108,7 +108,7 @@ def filter_backtrace(bt)
     end

     def code_around_binding
-      file, pos = @binding.eval('[__FILE__, __LINE__]')
+      file, pos = @binding.source_location

       unless defined?(::SCRIPT_LINES__[file]) && lines = ::SCRIPT_LINES__[file]
         begin
diff --git a/proc.c b/proc.c
index 9dbc78ae4a..23c4d3a2d4 100644
--- a/proc.c
+++ b/proc.c
@@ -12,6 +12,7 @@
 #include "eval_intern.h"
 #include "internal.h"
 #include "gc.h"
+#include "vm_core.h"
 #include "iseq.h"

 /* Proc.new with no block will raise an exception in the future
@@ -611,6 +612,24 @@ bind_receiver(VALUE bindval)
     return vm_block_self(&bind->block);
 }

+/*
+ *  call-seq:
+ *     binding.source_location  -> [String, Integer]
+ *
+ *  Returns the Ruby source filename and line number of the binding object.
+ */
+static VALUE
+bind_location(VALUE bindval)
+{
+    VALUE loc[2];
+    const rb_binding_t *bind;
+    GetBindingPtr(bindval, bind);
+    loc[0] = pathobj_path(bind->pathobj);
+    loc[1] = INT2FIX(bind->first_lineno);
+
+    return rb_ary_new4(2, loc);
+}
+
 static VALUE
 cfunc_proc_new(VALUE klass, VALUE ifunc, int8_t is_lambda)
 {
@@ -3223,5 +3242,6 @@ Init_Binding(void)
     rb_define_method(rb_cBinding, "local_variable_set", bind_local_variable_set, 2);
     rb_define_method(rb_cBinding, "local_variable_defined?", bind_local_variable_defined_p, 1);
     rb_define_method(rb_cBinding, "receiver", bind_receiver, 0);
+    rb_define_method(rb_cBinding, "source_location", bind_location, 0);
     rb_define_global_function("binding", rb_f_binding, 0);
 }

Associated revisions

Revision 571e48b7
Added by mame (Yusuke Endoh) 7 months ago

proc.c (bind_location): Add Binding#source_location

Fixes #14230

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 61480
Added by mame (Yusuke Endoh) 7 months ago

proc.c (bind_location): Add Binding#source_location

Fixes #14230

Revision 3095f4ec
Added by mame (Yusuke Endoh) 5 months ago

  • NEWS: add NEWS entry about Binding#source_location [Feature #14230]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62517 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 62517
Added by mame (Yusuke Endoh) 5 months ago

  • NEWS: add NEWS entry about Binding#source_location [Feature #14230]

History

#1 [ruby-core:84441] Updated by shevegen (Robert A. Heiler) 7 months ago

I like introspection so I am usually in agreement with all ways
to inspect ruby's behaviour.

+1

I also agree that eval-binding is not pretty.

#3 Updated by mame (Yusuke Endoh) 7 months ago

  • Status changed from Open to Closed

Applied in changeset trunk|r61480.


proc.c (bind_location): Add Binding#source_location

Fixes #14230

Also available in: Atom PDF