Bug #14247: Thread#fetch raise KeyError without key and receiver

• Status: Closed
• Assignee: znz (Kazuhiro NISHIYAMA)
• Target version: -
• ruby -v: ruby 2.6.0dev (2017-12-27 trunk 61494) [x86_64-linux]
• Backport: 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONE

[znz (Kazuhiro NISHIYAMA)]

I found this by message without Did you mean?.

expected:

% ruby -e 'th=Thread.current;th[:foo]=1;th.fetch(:fooo)'
Traceback (most recent call last):
        1: from -e:1:in `<main>'
-e:1:in `fetch': key not found: "fooo" (KeyError)
Did you mean?  :foo

actual:

% ruby -e 'th=Thread.current;th[:foo]=1;th.fetch(:fooo)'
Traceback (most recent call last):
        1: from -e:1:in `<main>'
-e:1:in `fetch': key not found: fooo (KeyError)

[nobu (Nobuyoshi Nakada)]

The given key is :fooo symbol, so the message should be :fooo but not "fooo".
Use "%+"PRIsVALUE instead of "\"%"PRIsVALUE"\"" for inspection.

[znz (Kazuhiro NISHIYAMA)]

• File 0001-Fix-KeyError-key-receiver-of-Thread-fetch.patch 0001-Fix-KeyError-key-receiver-of-Thread-fetch.patch added

Update patch.

% ruby -e 'th=Thread.current;th[:foo]=1;th.fetch(:fooo)'
Traceback (most recent call last):
        1: from -e:1:in `<main>'
-e:1:in `fetch': key not found: :fooo (KeyError)
Did you mean?  :foo
% ruby -e 'th=Thread.current;th[:foo]=1;th.fetch("fooo")'
Traceback (most recent call last):
        1: from -e:1:in `<main>'
-e:1:in `fetch': key not found: "fooo" (KeyError)
Did you mean?  :foo

[shevegen (Robert A. Heiler)]

Indeed. I actually had to look twice to see the error. :)

• Status changed from Assigned to Closed

Applied in changeset trunk|r61507.

---

Fix KeyError#{key,receiver} of Thread#fetch

[ruby-core:84508] [Bug #14247]

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED

[naruse (Yui NARUSE)]

• Backport changed from 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONE

ruby_2_5 r61583 merged revision(s) 61507.