Project

General

Profile

Bug #14420

[BUG] Unnormalized Fixnum value on Rational#hash.to_s

Added by Eregon (Benoit Daloze) 12 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
ruby -v:
ruby 2.4.3p205 (2017-12-14 revision 61247) [x64-mingw32]
[ruby-core:85224]

Description

p eval("(Rational(1, 2)).hash.to_s")

causes a crash on Windows 64-bit, for both Ruby 2.4 and trunk.
Ruby 2.3 seems fine.

Here is a failure log:
https://ci.appveyor.com/project/eregon/windows-shell

Associated revisions

Revision 0d92f156
Added by normal about 1 year ago

webrick/httpservelet/cgi_runner: avoid IO#reopen on pathname

IO#reopen seems to behave strangely on Win32 based on the logs
posted by Greg for [Bug #14420]. Lets try to fix the issue by
using File.open explicitly (but not Kernel#open).

  • lib/webrick/httpservelet/cgi_runner: use File.open explicitly [Bug #14220]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61409 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 61409
Added by normal about 1 year ago

webrick/httpservelet/cgi_runner: avoid IO#reopen on pathname

IO#reopen seems to behave strangely on Win32 based on the logs
posted by Greg for [Bug #14420]. Lets try to fix the issue by
using File.open explicitly (but not Kernel#open).

  • lib/webrick/httpservelet/cgi_runner: use File.open explicitly [Bug #14220]

Revision 61409
Added by normal about 1 year ago

webrick/httpservelet/cgi_runner: avoid IO#reopen on pathname

IO#reopen seems to behave strangely on Win32 based on the logs
posted by Greg for [Bug #14420]. Lets try to fix the issue by
using File.open explicitly (but not Kernel#open).

  • lib/webrick/httpservelet/cgi_runner: use File.open explicitly [Bug #14220]

Revision 3f7221ad
Added by nobu (Nobuyoshi Nakada) 12 months ago

force fixable

  • complex.c (nucomp_hash): force hash values fixable.
    [ruby-core:85224] [Bug #14420]

  • rational.c (nurat_hash): ditto.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62107 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 62107
Added by nobu (Nobuyoshi Nakada) 12 months ago

force fixable

  • complex.c (nucomp_hash): force hash values fixable.
    [ruby-core:85224] [Bug #14420]

  • rational.c (nurat_hash): ditto.

Revision 62107
Added by nobu (Nobuyoshi Nakada) 12 months ago

force fixable

  • complex.c (nucomp_hash): force hash values fixable.
    [ruby-core:85224] [Bug #14420]

  • rational.c (nurat_hash): ditto.

Revision 4724dea4
Added by naruse (Yui NARUSE) 11 months ago

merge revision(s) 62107: [Backport #14420]

force fixable

* complex.c (nucomp_hash): force hash values fixable.
  [ruby-core:85224] [Bug #14420]

* rational.c (nurat_hash): ditto.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62538 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 62538
Added by naruse (Yui NARUSE) 11 months ago

merge revision(s) 62107: [Backport #14420]

force fixable

* complex.c (nucomp_hash): force hash values fixable.
  [ruby-core:85224] [Bug #14420]

* rational.c (nurat_hash): ditto.

Revision bb9a770c
Added by nagachika (Tomoyuki Chikanaga) 10 months ago

merge revision(s) 62107: [Backport #14420]

force fixable

* complex.c (nucomp_hash): force hash values fixable.
  [ruby-core:85224] [Bug #14420]

* rational.c (nurat_hash): ditto.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 62877
Added by nagachika (Tomoyuki Chikanaga) 10 months ago

merge revision(s) 62107: [Backport #14420]

force fixable

* complex.c (nucomp_hash): force hash values fixable.
  [ruby-core:85224] [Bug #14420]

* rational.c (nurat_hash): ditto.

History

#3

Updated by nobu (Nobuyoshi Nakada) 12 months ago

  • Status changed from Open to Closed

Applied in changeset trunk|r62107.


force fixable

  • complex.c (nucomp_hash): force hash values fixable.
    [ruby-core:85224] [Bug #14420]

  • rational.c (nurat_hash): ditto.

Updated by Eregon (Benoit Daloze) 11 months ago

  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: UNKNOWN, 2.4: REQUIRED, 2.5: REQUIRED

I believe this should be backported to 2.4 and 2.5.

Updated by naruse (Yui NARUSE) 11 months ago

  • Backport changed from 2.3: UNKNOWN, 2.4: REQUIRED, 2.5: REQUIRED to 2.3: UNKNOWN, 2.4: REQUIRED, 2.5: DONE

ruby_2_5 r62538 merged revision(s) 62107.

Updated by nagachika (Tomoyuki Chikanaga) 10 months ago

  • Backport changed from 2.3: UNKNOWN, 2.4: REQUIRED, 2.5: DONE to 2.3: UNKNOWN, 2.4: DONE, 2.5: DONE

ruby_2_4 r62877 merged revision(s) 62107.

Also available in: Atom PDF