Project

General

Profile

Actions

Bug #14571

closed

File descriptor leak in resolv.rb

Added by quixoten (Devin Christensen) over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:85901]

Description

There's an edge case in resolv.rb that can lead to file descriptor leaks on a highly saturated system (logstash in our case).

file-descriptor-leak

(the cliff at the end is from a restart of the application)

We're using the logstash-filter-dns plugin which uses timeout.

When a timeout fires while waiting for a random port, the new object is never returned to the caller. Instead requester is set to nil. There's no handle to any sockets that were created in the initializer, so they can't be closed, and one ore more file descriptors is leaked.

(This if my first patch submission, let me know what I can fix or do better.)


Files

add-failing-tests.patch (1.39 KB) add-failing-tests.patch quixoten (Devin Christensen), 03/02/2018 07:09 PM
fix-leak.patch (5.01 KB) fix-leak.patch quixoten (Devin Christensen), 03/02/2018 07:09 PM
combined.patch (6.4 KB) combined.patch The two patches above combined. quixoten (Devin Christensen), 03/02/2018 07:09 PM
Actions

Also available in: Atom PDF