Bug #14600: test-all & REXML - fixup

• Status: Closed
• Assignee: kou (Kouhei Sutou)
• Target version: -
• ruby -v: ruby 2.6.0dev (2018-03-13 trunk 62739) [x64-mingw32]
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN

[MSP-Greg (Greg L)]

First of all, thanks to @nobu (Nobuyoshi Nakada) for 62738, a quick look shows that the variance in test count for both Travis & Appveyor is much smaller (or non-existent) than before.

Anyway, the main test patch that is still in Ruby-loco is a patch for REXML.

A link to the file is https://github.com/MSP-Greg/ruby-loco/blob/master/patches/test-rexml.patch, I've attached also.

I did the patch quite a while ago, so it's not quite 'front and center' in my mind. I was active in XML back when it was still being standardized and all the parsers were "don't try this at home". As I recall, the tests and their expectations are embedded in xml docs, idea being that any platform can run them. Something wasn't quite finished, which is why there's a increase in assertions of 215 after the patch is applied.

428 tests, 2650 assertions, 0 failures, 0 errors, 0 skips  - Test results before patch
417 tests, 2865 assertions, 0 failures, 0 errors, 0 skips  - Test results after

Thanks again, Greg

[kou (Kouhei Sutou)]

• Status changed from Open to Assigned
• Assignee set to kou (Kouhei Sutou)

[MSP-Greg (Greg L)]

• File rexml_test.txt rexml_test.txt added

To all & @kou (Kouhei Sutou)

Apologizes for not providing more detail. The results above are for tests not run parallel, which (as I recall) adds 3 asserts for every test. I've got the test system patched to account for that and also output the number of asserts for each test. I did not have that patch in place for the above results. True results are:

428 tests, 1366 assertions, 0 failures, 0 errors, 0 skips - Test results before patch
417 tests, 1614 assertions, 0 failures, 0 errors, 0 skips - Test results after

Hence, the assert differential is 248.

Almost all of changes are in the JaxenTester class. I've attached a tab delimited sheet of the asserts by test for patched and existing. 'na' means the test was removed in the patched version.

Thanks, Greg

[kou (Kouhei Sutou)]

• Status changed from Assigned to Closed

Applied in changeset trunk|r63057.

---

Start re-enabling Jaxen tests

[Bug #14600]
Reported by MSP-Greg. Thanks!!!

• lib/rexml/xpath_parser.rb: Fix a bug that "following_siblings::*[N]"
  doesn't work.

• test/rexml/test_jaxen.rb: Enable only axis test for now.

[kou (Kouhei Sutou)]

• Status changed from Closed to Assigned

Thanks for the information.
It's not completed yet but I start enabling Jaxen tests.

[MSP-Greg (Greg L)]

@kou (Kouhei Sutou),

Thanks for your work, Greg

[kou (Kouhei Sutou)]

• Status changed from Assigned to Closed

Applied in changeset commit:ruby-git|f0c734660faea02ce455b14e75e006bb4314e173.

---

Start re-enabling Jaxen tests

[Bug #14600]
Reported by MSP-Greg. Thanks!!!

• lib/rexml/xpath_parser.rb: Fix a bug that "following_siblings::*[N]"
  doesn't work.

• test/rexml/test_jaxen.rb: Enable only axis test for now.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63057 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

[kou (Kouhei Sutou)]

I've enabled almost tests.
The tests reveals some XPath related bugs. They are good tests.

I've fixed most of the XPath related bugs. Namespace axis related XPath isn't fixed yet. I'll work on it later.