Bug #1627

Kernel.require Should Canonicalise Paths

Added by Run Paint Run Run over 5 years ago. Updated almost 4 years ago.

[ruby-core:23845]
Status:Closed
Priority:Normal
Assignee:-
ruby -v:ruby 1.9.2dev (2009-06-13 trunk 23682) [i686-linux] Backport:

Description

=begin
Kernel.require on 1.9 is far saner than 1.8 with respect to normalizing path names before storing them in $". To use the example from the rdoc, require 'a' and require './a' are now correctly regarded as identical, causing 'a' to be loaded only once. (I have a separate ticket open to update the rdoc).

However, there are still a couple of edge cases when paths aren't normalised.

 >> require '/tmp/../tmp/c.rb'
 c.rb
 => true
 >> require '/tmp/c.rb'
 c.rb
 => true
 >> require '/../../../tmp/c.rb'
 c.rb
 => true
 >> $".grep /c.rb/
 => ["/tmp/../tmp/c.rb", "/tmp/c.rb", "/../../../tmp/c.rb"]

Another is that multiple consecutive separators are not collapsed:

 >> require '/tmp/c.rb'
 c.rb
 => true
 >> require '/tmp//c.rb'
 c.rb
 => true
 >> $".grep /c.rb/
 => ["/tmp/c.rb", "/tmp//c.rb"]

However, tilde expansion is handled correctly:

 >> require '/tmp/c'
 c.rb
 => true
 >> require '~/../../tmp/c'
 => false
 >> $".grep /c.rb/
 => ["/tmp/c.rb"]

In all cases the path should be expanded and made absolute before being stored in $". This would presumably aid performance, avoid files being inadvertently loaded multiple times, and be more consistent.

(As an aside, all filenames in $" on my system are absolute apart from 'enumerator.so', which is relative. It would be more consistent if all such paths were absolute.)
=end

History

#1 Updated by Nobuyoshi Nakada over 5 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
Applied in changeset r23689.
=end

#2 Updated by Heesob Park over 5 years ago

=begin
In addition, require './a.rb' and require '.\a.rb' should be regarded as identical on Windows.

=end

#3 Updated by Yukihiro Matsumoto over 5 years ago

=begin
Hi,

In message "Re: [Bug #1627] Kernel.require Should Canonicalise Paths"
on Sun, 14 Jun 2009 11:00:48 +0900, Heesob Park redmine@ruby-lang.org writes:

|In addition, require './a.rb' and require '.\a.rb' should be regarded as identical on Windows.

No, never use backslash path separator for #require.

                        matz.

=end

#4 Updated by Yukihiro Matsumoto over 5 years ago

=begin
Hi,

In message "Re: [Bug #1627] Kernel.require Should Canonicalise Paths"
on Sun, 14 Jun 2009 07:34:32 +0900, Run Paint Run Run redmine@ruby-lang.org writes:

|(As an aside, all filenames in $" on my system are absolute apart from 'enumerator.so', which is relative. It would be more consistent if all such paths were absolute.)

enumerator.so in $" is a compatibility hack, which will eventually be
removed in the future. It's now built-in, so it does not have any
absolute path.

                        matz.

=end

Also available in: Atom PDF