Project

General

Profile

Actions

Bug #16834

closed

rb_profile_frame_classpath only recognize class singleton methods, not module singleton methods

Added by byroot (Jean Boussier) about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.5.5p157 ruby 2.6.6p146 ruby 2.8.0dev
[ruby-core:98154]

Description

Proposed patch: https://github.com/ruby/ruby/pull/3084

Right now SomeClass.method is properly named, but SomeModule.method
is displayed as #<Module:0x000055eb5d95adc8>.method which makes
profiling annoying.

This particularly impact StackProf.

it's a problem at least since Ruby 2.5, maybe older but there's not point backporting that far back.

Updated by tenderlovemaking (Aaron Patterson) about 2 years ago

  • Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN to 2.5: REQUIRED, 2.6: REQUIRED, 2.7: REQUIRED

I've merged this in cbe4f75ef802f13d05f94e42274b65a062bd3666. It's been a bug for a while so I'm going to mark back port for 2.5, 2.6, and 2.7. 🙇🏻‍♂️

Actions #2

Updated by jeremyevans0 (Jeremy Evans) about 2 years ago

  • Status changed from Open to Closed

Updated by nagachika (Tomoyuki Chikanaga) almost 2 years ago

  • Backport changed from 2.5: REQUIRED, 2.6: REQUIRED, 2.7: REQUIRED to 2.5: REQUIRED, 2.6: REQUIRED, 2.7: DONE

ruby_2_7 12391cdbe11f3fbeb3b04c30b944139e5bbd9ea6 merged revision(s) cbe4f75ef802f13d05f94e42274b65a062bd3666.

Updated by usa (Usaku NAKAMURA) about 1 year ago

  • Backport changed from 2.5: REQUIRED, 2.6: REQUIRED, 2.7: DONE to 2.5: REQUIRED, 2.6: DONE, 2.7: DONE

ruby_2_6 r67918 merged revision(s) 12391cdbe11f3fbeb3b04c30b944139e5bbd9ea6.

Actions

Also available in: Atom PDF