Project

General

Profile

Actions

Feature #17259

closed

Kernel#warn should ignore <internal: entries

Added by Eregon (Benoit Daloze) over 3 years ago. Updated over 3 years ago.

Status:
Closed
Assignee:
-
Target version:
[ruby-core:100357]

Description

Kernel#warn currently does not skip <internal: entries from core library methods defined in Ruby.
This can cause rather unhelpful locations to be used for warnings.

For instance:

$ ruby -v --disable=gems -e 'def deprecated; warn "use X instead", uplevel: 1; end; tap(&:deprecated)'
ruby 3.0.0preview1 (2020-09-25 master 0096d2b895) [x86_64-linux]
<internal:kernel>:90: warning: use X instead
# expected: "-e:1: warning: use X instead"

Note that RubyGems overrides Kernel#warn since https://github.com/rubygems/rubygems/pull/2442 and https://github.com/rubygems/rubygems/blob/c1bafab1d84e0aad06e377e9db4b74cccab4b43a/lib/rubygems/core_ext/kernel_warn.rb#L42,
so --disable-gems is needed to observe this behavior.
I think it is very suboptimal that RubyGems needs to monkey-patch Kernel#warn to remove RubyGems' require from Kernel#warn location.
That is both fragile (as we've seen from various incompatible behavior and bugs in that monkey-patch) and inefficient (walking the stack multiple times).

So I would suggest to actually skip all backtraces entries starting with <internal: for Kernel#warn(message, uplevel:).
BTW this is already what TruffleRuby does.

As a bonus, by filtering out <internal:, RubyGems could define its require in an eval(code, nil, '<internal:rubygems-require>', line) and it would automatically be skipped, without needing to monkey-patch Kernel#warn at all!

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0