Project

General

Profile

Actions

Bug #17850

closed

`PAGE_SIZE` is no longer a constant for macOS

Added by xtkoba (Tee KOBAYASHI) 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:103727]

Description

Build failure for macOS Big Sur (ARM) due to -Wundef (#17752).

It is said in https://www.wwdcnotes.com/notes/wwdc20/10214/ that:

  • Native page size on Intel is 4 kB, on Apple Silicon it's 16 kB: therefore the PAGE_SIZE macro is no longer a constant. Use:
    • PAGE_MAX_SIZE for a compile-time upper bound
    • vm_page_size to read the actual value at runtime

Related issues

Related to Ruby master - Feature #17752: Enable -Wundef for C extensions in repositoryClosedEregon (Benoit Daloze)Actions
Actions #1

Updated by Eregon (Benoit Daloze) 5 months ago

  • Related to Feature #17752: Enable -Wundef for C extensions in repository added

Updated by Eregon (Benoit Daloze) 5 months ago

I wonder why Apple didn't simply define PAGE_SIZE conditionally based on the architecture.

Updated by peterzhu2118 (Peter Zhu) 5 months ago

  • Assignee set to peterzhu2118 (Peter Zhu)

Updated by peterzhu2118 (Peter Zhu) 5 months ago

Thank you. I'm looking into this.

Actions #5

Updated by peterzhu2118 (Peter Zhu) 5 months ago

  • Backport changed from 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN to 2.6: DONTNEED, 2.7: DONTNEED, 3.0: DONTNEED

Updated by mame (Yusuke Endoh) 5 months ago

  • Status changed from Open to Closed

nobu (Nobuyoshi Nakada) seemed to fix this issue by 3d5b6ddff8def49e59fb9a9ddd28a653498ae861 and 192150051144c0242ee44df26952dfe31b83cac2

Actions

Also available in: Atom PDF