Project

General

Profile

Actions

Feature #20524

closed

mswin and gmp

Added by MSP-Greg (Greg L) 7 months ago. Updated 7 months ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:118173]

Description

Currently, the vcpkg.json file exists, and it can be used to specify what MSFT/vcpkg packages to install, and also a repo commit, which will determine the what package versions are used. The file lists the gmp package.

  1. To use the gmp package in mswin, win32/configure.bat shows an option of --with-gmp. This option is not used in the windows.yml workflow file, nor is it mentioned in doc/windows.md.

  2. When using the option, the build fails when compiling bignum.c, as it can’t find gmp.h. It appears the vcpkg include folder is not being passed to cl?

So, it seems a few things are amiss. gmp was added a long time ago. With current mswin builds, will gmp improve Bignum’s performance? Is that unknown? If there are benchmarks to determine this, I could certainly run them…

Actions #1

Updated by nobu (Nobuyoshi Nakada) 7 months ago

  • Tracker changed from Misc to Bug
  • Backport set to 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED
Actions #2

Updated by nobu (Nobuyoshi Nakada) 7 months ago

  • Status changed from Open to Closed

Applied in changeset git|065190a973c9534b93e3ff99b789bcc945032dfd.


[Bug #20524] win32: Try to configure GMP if available

Updated by nagachika (Tomoyuki Chikanaga) 7 months ago

  • Backport changed from 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED to 3.1: WONTFIX, 3.2: WONTFIX, 3.3: REQUIRED

I think this is a kind of new feature of ruby build system. I won't backport it to 3.2 branch. It's up to kokubun-san for 3.3 branch.

Updated by k0kubun (Takashi Kokubun) 7 months ago

  • Tracker changed from Bug to Feature
  • Backport deleted (3.1: WONTFIX, 3.2: WONTFIX, 3.3: REQUIRED)

seems like a new feature to me too. I won't backport it to 3.3.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0