Project

General

Profile

Actions

Bug #20687

closed

Does tarball require baseruby?

Added by hsbt (Hiroshi SHIBATA) 4 months ago. Updated 4 months ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:118906]

Description

From https://github.com/rbenv/ruby-build/issues/2435

I'm wondering why tarball use system ruby with above environment. In my understanding, tarball don't need baseruby.

Is it intentional?

Updated by nobu (Nobuyoshi Nakada) 4 months ago

In that case, the system ruby is used to re-check encoding sources and update encdb.h if needed.
Encodings under enc directory will be added to encdb.h automatically by template/encdb.h.tmpl file.
We assume that the cost to re-check using ruby is much less than the cost for rebuild all encodings, or the cost to re-check using other than ruby.

Another assumption is that the system ruby provides full of bundled libraries, ArchLinux is not the case apparently.
I'll add a check that the system ruby matches our assumption.

Actions #3

Updated by nobu (Nobuyoshi Nakada) 4 months ago

  • Status changed from Open to Closed

Applied in changeset git|6ab591f80aa19d63ecd1e1df3c09c391efb318a6.


[Bug #20687] Check if base ruby provides necessary libraries

Updated by vo.x (Vit Ondruch) 4 months ago

nobu (Nobuyoshi Nakada) wrote in #note-1:

In that case, the system ruby is used to re-check encoding sources and update encdb.h if needed.

Why miniruby is not used for that purpose?

Actions #5

Updated by hsbt (Hiroshi SHIBATA) 4 months ago

  • Status changed from Closed to Open

Updated by nobu (Nobuyoshi Nakada) 4 months ago

vo.x (Vit Ondruch) wrote in #note-4:

nobu (Nobuyoshi Nakada) wrote in #note-1:

In that case, the system ruby is used to re-check encoding sources and update encdb.h if needed.

Why miniruby is not used for that purpose?

Now miniruby is used if erb is not available.

Updated by mame (Yusuke Endoh) 4 months ago

  • Status changed from Open to Closed

This issue happens only when ruby is installled but erb is not installed. 6ab591f80aa19d63ecd1e1df3c09c391efb318a6 checks if not only ruby but also erb is installed. So I think the issue itself is already resolved. Using miniruby for rebuilding encdb.h is a different issue.

Actions

Also available in: Atom PDF

Like1
Like1Like0Like0Like0Like0Like0Like0