Bug #21014: Prism doesn't set node_id on iseqs correctly

• Status: Closed
• Assignee: prism
• Target version: -
• Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONTNEED, 3.4: DONE

[tenderlovemaking (Aaron Patterson)]

Given this code:

f = proc { <<END }
  heredoc
END

iseq = RubyVM::InstructionSequence.of(f)
p iseq.to_a[4][:node_id]

Output on parse.y:

$ ./miniruby --parser=parse.y test.rb
3

Output on Prism:

$ ./miniruby test.rb
-1

I don't expect node IDs on Prism to match parse.y, but I do expect the node id to be a legitimate node id. For example, this program should work:

f = proc { <<END }
  heredoc
END

iseq = RubyVM::InstructionSequence.of(f)

require "prism"

node_id = iseq.to_a[4][:node_id]

ast = Prism.parse(File.binread(__FILE__))
p ast.value.breadth_first_search { |node| node.node_id == node_id }

[tenderlovemaking (Aaron Patterson)]

Fix sent here: https://github.com/ruby/ruby/pull/12527

[tenderlovemaking (Aaron Patterson)]

• Status changed from Open to Closed

Applied in changeset git|63723c8d5908569918fb27e070ae5bc9de33c8bd.

---

Correctly set node_id on iseq location

The iseq location object has a slot for node ids. parse.y was correctly
populating that field but Prism was not. This commit populates the field
with the ast node id for that iseq

[Bug #21014]

[kddnewton (Kevin Newton)]

• Backport changed from 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN to 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: REQUIRED

[k0kubun (Takashi Kokubun)]

• Backport changed from 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: REQUIRED to 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: DONE

ruby_3_4 9240f01b1fbe5ea4f6a2017d35f8f605f84f0039 merged revision(s) 63723c8d5908569918fb27e070ae5bc9de33c8bd.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: DONE to 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONTNEED, 3.4: DONE