Project

General

Profile

Actions

Bug #21847

closed

Backport `syntax_suggest` 2.0.3 to supported branches

Bug #21847: Backport `syntax_suggest` 2.0.3 to supported branches
1

Added by Earlopain (Earlopain _) 1 day ago. Updated 1 day ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:124604]

Description

Prism contains a translation layer for ripper, which until very recently didn't emit on_sp tokens. This has now been implemented to improve compatibility.

However right after merging some syntax_suggest tests started failing: https://gist.github.com/schneems/834c75345b2085bda54dab69d913bcc0. syntax_suggest is using the ripper translation layer and is working around the missing on_sp tokens. Now that they are correctly created by prism, syntax_suggest is not able to handle these.

For prism this is just a bugfix but I do not want to break syntax_suggest unnecessarily. I asked @schneems (Richard Schneeman) and this is what he had to say about it: https://github.com/ruby/syntax_suggest/pull/243#issuecomment-3779113958

Backport PRs:

Updated by Earlopain (Earlopain _) 1 day ago Actions #1

  • Description updated (diff)

Updated by Earlopain (Earlopain _) 1 day ago Actions #2

  • Status changed from Open to Closed
Actions

Also available in: PDF Atom