Bug #22326: heap buffer overflow in array.values_at()

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: 4.1.0dev
• Backport: 3.3: WONTFIX, 3.4: DONE, 4.0: DONE

[danielchong (Daniel Chong)]

Hello, I discovered a heap buffer overflow in array.values_at(). I believe the root issue/potential fix is similar to #22325, but the code paths are distinct.

PoC:

class bad < Numeric
  def initialize(v); @v = v; end
  def val; @v; end
  def <=>(o); @v <=> (o.is_a?(bad) ? o.val : o); end
  def to_int; $a.clear; @v; end
  def to_i; @v; end
  def coerce(o); [o, @v]; end
end
$a = (1..3000).to_a
$a.values_at(Range.new(bad.new(2900), bad.new(2950)))   

asan output (truncated):

ERROR: AddressSanitizer: heap-buffer-overflow ... READ of size 408 ...
    #3 ary_memcpy0             array.c:354
    #4 rb_ary_cat              array.c:1417
    #5 append_values_at_single array.c:3970
    #6 rb_ary_values_at        array.c:4096

[peterzhu2118 (Peter Zhu)]

• Backport changed from 3.3: UNKNOWN, 3.4: UNKNOWN, 4.0: UNKNOWN to 3.3: WONTFIX, 3.4: REQUIRED, 4.0: REQUIRED

Thank you for this bug report. I believe this PR should have fixed this bug. I will mark this issue for backport.

[mame (Yusuke Endoh)]

• Status changed from Open to Closed

[k0kubun (Takashi Kokubun)]

• Backport changed from 3.3: WONTFIX, 3.4: REQUIRED, 4.0: REQUIRED to 3.3: WONTFIX, 3.4: REQUIRED, 4.0: DONE

ruby_4_0 738b4971c635246ad33c87263ddef5bb160ab255.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 3.3: WONTFIX, 3.4: REQUIRED, 4.0: DONE to 3.3: WONTFIX, 3.4: DONE, 4.0: DONE

ruby_3_4 a1c96b6b0fb3755fe14776e8a23d81088025a788 merged revision(s) 3f6143715aa934b558f0b97462b42793c845e4d7.