Feature #3511: rb_path_to_class should call custom const_defined? methods

• Status: Closed
• Assignee: -
• Target version: -

[tenderlovemaking (Aaron Patterson)]

=begin
It would be nice if rb_path_to_class called custom const_defined? methods. This would give marshaled objects a chance to locate and define classes when they are being unmarshalled.

I've attached a patch with a test that demonstrates the desired functionality and a (probably naive) implementation.
=end

[nahi (Hiroshi Nakamura)]

• Description updated (diff)
• Status changed from Open to Feedback

Aaron, is this hook extension still needed for your usecase? (assuming Rails?)

Not bad but it would affect performance...

[mame (Yusuke Endoh)]

• Target version set to 2.6

[oggy (George Ogata)]

Hiroshi Nakamura wrote:

Aaron, is this hook extension still needed for your usecase? (assuming Rails?)

Not bad but it would affect performance...

Would this idea still be considered? I find this issue comes up fairly frequently in Rails apps when an object is serialized and deserialized in a separate process.

I think the performance problem could be addressed by keeping the rb_const_defined call, and then only if that fails try the rb_funcall. WDYT?

[oggy (George Ogata)]

• File marshal-dynamic.patch marshal-dynamic.patch added

I've attached an updated patch for current ruby trunk, which I think is a little more consistent with non-lazily-defined constant lookup. Also simplified the test case a little.

[matz (Yukihiro Matsumoto)]

• Status changed from Feedback to Closed

This is kind of autoload that sometimes cause problems.
I think it can cause issues than solving problem.
If you have a concrete use-case of this feature, please reopen.

Matz.

[oggy (George Ogata)]

Thanks for considering!

I've opened a new ticket and described my concrete use case, as I don't see a way to reopen this one.

https://bugs.ruby-lang.org/issues/12731